Add WIP docstrings to CPU and GPU #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhairyaLGandhi
previously approved these changes
Jun 26, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 26, 2021
1632: Add WIP docstrings to CPU and GPU r=DhairyaLGandhi a=logankilpatrick We could surely use more details, but ideally we would want to document these functions and what they do + usage. Co-authored-by: Logan Kilpatrick <23kilpatrick23@gmail.com> Co-authored-by: Dhairya Gandhi <dhairya@juliacomputing.com>
|
Canceled. |
|
bors r- Just wanted to get an opinion on whether to include details about needing a CUDA compatible GPU atm. Also, good to add an example for each, ideally with a simple model. |
|
Given #1566, I don't think it's necessary to include details about GPU compat for CUDA specifically. |
|
Would a simple example like: julia> m = Dense(10, 5)
Dense(10, 5)
julia> cpu(m)
Dense(10, 5)work? |
|
That'd work, i would also show that the types of arrays have changed to a |
|
I don't have an Nvidia GPU, can you add that example? |
|
Done. |
darsnack
requested changes
Jun 26, 2021
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
|
I tried to address the comments, please let me know if more needs to be updated! |
ToucheSir
approved these changes
Aug 22, 2021
darsnack
approved these changes
Aug 22, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could surely use more details, but ideally we would want to document these functions and what they do + usage.