Conv constructor should accept scalar pad/stride

[MikeInnes]

and just expand them to N dimensions.

So should the pooling function (so the logic probably needs to go in NNlib).

[tejank10]

I'll take this up

[tejank10]

Would that mean instead of

Conv(k::NTuple{N,Integer}, ch::Pair{<:Integer,<:Integer}, σ = identity; init = initn,
     stride::NTuple{N,Integer} = map(_->1,k),
     pad::NTuple{N,Integer} = map(_->0,k))

we should have something like

Conv(k::NTuple{N,Integer}, ch::Pair{<:Integer,<:Integer}, σ = identity; init = initn,
     stride::Integer = 1, pad::Integer = 0)

?
Because both of them cannot exist together. Please correct me if I am mistaken.

[MikeInnes]

They can exist together, but you'll obviously have to remove the types. Higher-level constructors can default to 1/0 and forward whatever they are given. When we actually construct a conv object, call some function like

expand(::Val{N}, i::Integer) = ntuple(_ -> i, Val{N})
expand(::Val{N}, i::NTuple{N}) = i
# error

In the conv case, N is ndims(weight)-2. In the pooling case it's length(kernel).

[tejank10]

I had tried that approach, and it gave me method overwriting warnings. It was something like the following:

Conv(k::NTuple{N,Integer}, ch::Pair{<:Integer,<:Integer}, σ = identity; init = initn,
     stride::Integer = 1, pad::Integer = 0) where N =
  Conv(param(init(k..., ch...)), param(zeros(ch[2])), σ,
       stride = map(_->stride,k), pad = map(_->pad,k))

[MikeInnes]

Right, don't use dispatch in the Conv constructor for this, just dispatch inside expand at the last minute. If that's not clear I'll put up a code snippet.

[MikeInnes]

Closed by #237.