-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conv constructor should accept scalar pad/stride #235
Comments
I'll take this up |
Would that mean instead of
we should have something like
? |
They can exist together, but you'll obviously have to remove the types. Higher-level constructors can default to
In the conv case, |
I had tried that approach, and it gave me method overwriting warnings. It was something like the following:
|
Right, don't use dispatch in the |
Closed by #237. |
and just expand them to N dimensions.
So should the pooling function (so the logic probably needs to go in NNlib).
The text was updated successfully, but these errors were encountered: