Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Additional Parameters did not take effect. #2499

Open
zhujinchong opened this issue May 28, 2024 · 2 comments
Open

[BUG] Additional Parameters did not take effect. #2499

zhujinchong opened this issue May 28, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@zhujinchong
Copy link

Describe the bug

In ChatOpenAI Custom, I want to customize the stop word. I placed this parameter in BaseOptions, but when making a request, the parameter was not passed.

examples:
stop: ["<|im_end|>"]
@HenryHengZJ
Copy link
Contributor

Currently we don't have stopSequences yet in ChatOpenAI Additional Config

@HenryHengZJ HenryHengZJ added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 31, 2024
@definitelynotchirag
Copy link
Contributor

@HenryHengZJ Hey I made about it, could you check it out? #3388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HenryHengZJ @zhujinchong @definitelynotchirag