Replace "Forgot pass phrase?" on pass phrase dialog when key_manager_url OrgRule is set

[tomholub]

Instead of the "Forgot pass phrase?" link, there should be text that says "Ask your IT staff for help if you lost your pass phrase."

[martgil]

I think I have managed to fix this issue by adding a check using this.orgRules.usesKeyManager() in passphrase.ts

[tomholub]

That looks good but is that still a link? It looks like the user could click it and go somewhere we don't want them to go.

[martgil]

When the link was clicked, the pop-up help for "Non-FES" user is shown.

Maybe we can update or add the description for "FES" user. Or maybe we could just disable the link?

[tomholub]

Let's disable the link when the user uses EKM as you say

[tomholub]

There's a test that uses EKM and also FORBID_STORING_PASS_PHRASE org rule. That test will be using the pass phrase dialog, I think. You can add a line to that test to verify the content has changed and is not clickable. Thanks!

[martgil]

I have tried to understand how ava testing was implemented in the flowcrypt-browser but I can't able to absorb what's happening inside the code. Can I help somebody once I get it, I'm going to add the test for the changes that I have made hopefully. Pardon me for any inconvenience.

[tomholub]

@martgil see if "Running tests locally" in https://github.com/FlowCrypt/flowcrypt-browser/wiki will help you. After that, please ask a more specific question and we'll be able to help or demonstrate. Thanks!

[martgil]

Hi @tomholub. Thanks for that. I think I have found it. There is currently a test that involves the passphrase.htm but the test is not specifically dedicated to user who has a FES account. Would you like me to add a specific test instead? The test will check if the user does have FORBID_STORING_PASS_PHRASE org rule and then if the DOM has indeed change the text and removed the href. I will try to do this and hopefully finished the test on moved on to the other tasks.

[tomholub]

Could you point me to the test you found?