Fix System.PlatformNotSupportedException & Add exception message box in App constructor #3283

Jack251970 · 2025-02-26T07:33:48Z

From #3275.

gitstream-cm · 2025-02-26T07:34:59Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Jack251970 · 2025-02-26T07:35:31Z

@taooceros Hello, I am trying to fix System.PlatformNotSupportedException for installer here.

coderabbitai · 2025-02-26T07:36:02Z

📝 Walkthrough

Walkthrough

This pull request enhances error handling in the application startup process. The App class constructor is modified to include try-catch blocks for initializing settings, the dependency injection container, and the public API. If exceptions occur, an error message is displayed, and the application exits. A new method, ShowErrorMsgBoxAndFailFast, centralizes error reporting. Additionally, the project file is updated to increment the versions of two package references.

Changes

File	Change Summary
Flow.Launcher/App.xaml.cs	Added `try-catch` blocks for settings and DI container initialization; introduced `ShowErrorMsgBoxAndFailFast` for centralized error handling.
Flow.Launcher/Flow.Launcher.csproj	Updated `Microsoft.Extensions.Hosting` from `7.0.0` to `7.0.1` and `TaskScheduler` from `2.11.0` to `Jack251970.TaskScheduler` version `2.12.1`.

Possibly related PRs

Fix Dependency Injection Issue #3275: Modifies error handling in the App class constructor and introduces the ShowErrorMsgBoxAndFailFast method, directly relating to the changes in this PR.

Suggested labels

enhancement, dependencies

Suggested reviewers

jjw24
taooceros

Poem

I'm a little rabbit, hopping with delight,
In code so robust, everything's set right.
With try-catch hops and error leaps so keen,
I watch for faults where none are seen!
Carrots of code, fresh and true, 🥕
Celebrating changes with a playful "woo-hoo!"

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a153bb6 and 406b196.

📒 Files selected for processing (1)

Flow.Launcher/Flow.Launcher.csproj (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Flow.Launcher/Flow.Launcher.csproj

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: gitStream.cm

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

taooceros · 2025-02-26T07:36:16Z

I guess probably just upgrade to .net 9 would fix this

Jack251970 · 2025-02-26T07:36:39Z

We should not upgrade the version, but instead we need to downgrade it.

taooceros · 2025-02-26T07:36:57Z

Task scheduler seems to use 8.0 dependency injection.

taooceros · 2025-02-26T07:37:49Z

We should not upgrade the version, but instead we need to downgrade it.

yeah if it works then let's go with this first.

Jack251970 · 2025-02-26T07:38:21Z

Task scheduler seems to use 8.0 dependency injection.

Really? Let us try this first.

Jack251970 · 2025-02-26T07:40:32Z

Oh, I forget to clean old codes.

Jack251970 · 2025-02-26T07:52:45Z

@taooceros Hello, can you download the installer? It seems that I have reached my daily limit...

taooceros · 2025-02-26T07:56:36Z

@taooceros Hello, can you download the installer? It seems that I have reached my daily limit...

That's shared among all of us...

taooceros · 2025-02-26T14:09:51Z

that's appveyor limit for a certain account (which is the same regardless who is trying to download)

github-actions · 2025-02-27T05:26:16Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jack251970 · 2025-02-27T05:45:31Z

that's appveyor limit for a certain account (which is the same regardless who is trying to download)

I have targeted the issue to be related the version of System.Diagnostics.EventLog package and have created PR for TaskScheduler (dahall/TaskScheduler#1004). Now we just need to wait this fix!

Jack251970 · 2025-02-28T01:20:45Z

@taooceros I think we can firstly merge this. When dahall/TaskScheduler#1004 is merged, we will move to that package.

taooceros · 2025-02-28T01:21:44Z

Sure, although I think net9 would also fix this issue (I haven't tested).

taooceros · 2025-02-28T01:21:57Z

Have you tested whether the fix work?

Jack251970 · 2025-02-28T01:26:45Z

Have you tested whether the fix work?

Yeah, I have tested.

Jack251970 · 2025-02-28T01:27:21Z

You can also check it by installing installer here.

Jack251970 · 2025-02-28T01:39:38Z

Sure, although I think net9 would also fix this issue (I haven't tested).

yeah, net9 can resolve this. and I just want to fix the usage of prereleased installers little quickly

Jack251970 · 2025-02-28T05:01:23Z

@taooceros Hello, could we merge it now? cibere need this fix for new api functions under dev branch.

taooceros

Sorry was taking lunch before. Looks cool!

gitstream-cm · 2025-03-13T10:25:00Z

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
jjw24, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

	Jack251970
MAR	5 additions & 16 deletions
FEB	79 additions & 40 deletions
JAN	86 additions & 66 deletions
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 38%
jjw24: 7%

Flow.Launcher/Flow.Launcher.csproj

Activity based on git-commit:

	Jack251970
MAR	1 additions & 1 deletions
FEB	11 additions & 10 deletions
JAN	4 additions & 2 deletions
DEC	4 additions & 0 deletions
NOV
OCT

Knowledge based on git-blame:
jjw24: 13%
Jack251970: 6%

To learn more about /:\ gitStream - Visit our Docs

Jack251970 added 3 commits February 26, 2025 15:26

Downgrade dependency injection version

bf8f5d1

Merge branch 'Flow-Launcher:dev' into dependency_injection_installer

2e511b0

Add message box to show exception

397c6ee

prlabeler bot added the bug Something isn't working label Feb 26, 2025

github-actions bot assigned Jack251970 Feb 26, 2025

This comment has been minimized.

Sign in to view

Fix build issue

7cc32f3

This comment has been minimized.

Sign in to view

gitstream-cm bot added the 1 min review label Feb 26, 2025

Upgrade nuget packages

fb9980e

This comment has been minimized.

Sign in to view

Test Jack251970.TaskScheduler package

a153bb6

This comment has been minimized.

Sign in to view

Test updated Jack251970.TaskScheduler package

406b196

Jack251970 mentioned this pull request Feb 27, 2025

Resolve EventLog compatibility dahall/TaskScheduler#1004

Closed

taooceros enabled auto-merge February 28, 2025 06:56

taooceros approved these changes Feb 28, 2025

View reviewed changes

taooceros merged commit 9329575 into Flow-Launcher:dev Feb 28, 2025
7 checks passed

Jack251970 mentioned this pull request Mar 5, 2025

Use official Task Scheduler #3313

Merged

Jack251970 added this to the 1.20.0 milestone Mar 13, 2025

Jack251970 removed the 1 min review label Mar 13, 2025

jjw24 added Dev branch only An issue or fix for the Dev branch build and removed bug Something isn't working labels Mar 19, 2025

coderabbitai bot mentioned this pull request Mar 22, 2025

Graceful shutdown #3367

Merged

1 task

Uh oh!

Fix System.PlatformNotSupportedException & Add exception message box in App constructor #3283

Fix System.PlatformNotSupportedException & Add exception message box in App constructor #3283

Uh oh!

Conversation

Jack251970 commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

gitstream-cm bot commented Feb 26, 2025

Uh oh!

Jack251970 commented Feb 26, 2025

Uh oh!

coderabbitai bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

taooceros commented Feb 26, 2025

Uh oh!

Jack251970 commented Feb 26, 2025

Uh oh!

taooceros commented Feb 26, 2025

Uh oh!

taooceros commented Feb 26, 2025

Uh oh!

Jack251970 commented Feb 26, 2025

Uh oh!

Jack251970 commented Feb 26, 2025

Uh oh!

This comment has been minimized.

Jack251970 commented Feb 26, 2025

Uh oh!

taooceros commented Feb 26, 2025

Uh oh!

taooceros commented Feb 26, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 27, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Uh oh!

Jack251970 commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jack251970 commented Feb 28, 2025

Uh oh!

taooceros commented Feb 28, 2025

Uh oh!

taooceros commented Feb 28, 2025

Uh oh!

Jack251970 commented Feb 28, 2025

Uh oh!

Jack251970 commented Feb 28, 2025

Uh oh!

Jack251970 commented Feb 28, 2025

Uh oh!

Jack251970 commented Feb 28, 2025

Uh oh!

taooceros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gitstream-cm bot commented Mar 13, 2025

Uh oh!

Uh oh!

Jack251970 commented Feb 26, 2025 •

edited

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Jack251970 commented Feb 27, 2025 •

edited

Loading