Skip to content

Commit 3de8005

Browse files
committed
Improve WebSearch project code quality
1 parent 4572068 commit 3de8005

File tree

4 files changed

+14
-26
lines changed

4 files changed

+14
-26
lines changed

Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/Baidu.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
using System.Text.Json;
55
using System.Text.RegularExpressions;
66
using System.Threading.Tasks;
7-
using Flow.Launcher.Infrastructure.Http;
8-
using Flow.Launcher.Infrastructure.Logger;
97
using System.Net.Http;
108
using System.Threading;
119

@@ -22,11 +20,11 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
2220
try
2321
{
2422
const string api = "http://suggestion.baidu.com/su?json=1&wd=";
25-
result = await Http.GetAsync(api + Uri.EscapeDataString(query), token).ConfigureAwait(false);
23+
result = await Main._context.API.HttpGetStringAsync(api + Uri.EscapeDataString(query), token).ConfigureAwait(false);
2624
}
2725
catch (Exception e) when (e is HttpRequestException or {InnerException: TimeoutException})
2826
{
29-
Log.Exception("|Baidu.Suggestions|Can't get suggestion from baidu", e);
27+
Main._context.API.LogException(nameof(Baidu), "Can't get suggestion from baidu", e);
3028
return null;
3129
}
3230

@@ -41,7 +39,7 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
4139
}
4240
catch (JsonException e)
4341
{
44-
Log.Exception("|Baidu.Suggestions|can't parse suggestions", e);
42+
Main._context.API.LogException(nameof(Baidu), "Can't parse suggestions", e);
4543
return new List<string>();
4644
}
4745

Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/Bing.cs

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using Flow.Launcher.Infrastructure.Http;
2-
using Flow.Launcher.Infrastructure.Logger;
3-
using System;
1+
using System;
42
using System.Collections.Generic;
53
using System.Net.Http;
64
using System.Threading.Tasks;
@@ -10,16 +8,15 @@
108

119
namespace Flow.Launcher.Plugin.WebSearch.SuggestionSources
1210
{
13-
class Bing : SuggestionSource
11+
public class Bing : SuggestionSource
1412
{
1513
public override async Task<List<string>> SuggestionsAsync(string query, CancellationToken token)
1614
{
17-
1815
try
1916
{
2017
const string api = "https://api.bing.com/qsonhs.aspx?q=";
2118

22-
await using var resultStream = await Http.GetStreamAsync(api + Uri.EscapeDataString(query), token).ConfigureAwait(false);
19+
await using var resultStream = await Main._context.API.HttpGetStreamAsync(api + Uri.EscapeDataString(query), token).ConfigureAwait(false);
2320

2421
using var json = (await JsonDocument.ParseAsync(resultStream, cancellationToken: token));
2522
var root = json.RootElement.GetProperty("AS");
@@ -33,18 +30,15 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
3330
.EnumerateArray()
3431
.Select(s => s.GetProperty("Txt").GetString()))
3532
.ToList();
36-
37-
38-
3933
}
4034
catch (Exception e) when (e is HttpRequestException or { InnerException: TimeoutException })
4135
{
42-
Log.Exception("|Baidu.Suggestions|Can't get suggestion from baidu", e);
36+
Main._context.API.LogException(nameof(Bing), "Can't get suggestion from baidu", e);
4337
return null;
4438
}
4539
catch (JsonException e)
4640
{
47-
Log.Exception("|Bing.Suggestions|can't parse suggestions", e);
41+
Main._context.API.LogException(nameof(Bing), "Can't parse suggestions", e);
4842
return new List<string>();
4943
}
5044
}

Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/DuckDuckGo.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
using System.Collections.Generic;
33
using System.Linq;
44
using System.Threading.Tasks;
5-
using Flow.Launcher.Infrastructure.Http;
6-
using Flow.Launcher.Infrastructure.Logger;
75
using System.Net.Http;
86
using System.Threading;
97
using System.Text.Json;
@@ -25,7 +23,7 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
2523
{
2624
const string api = "https://duckduckgo.com/ac/?type=list&q=";
2725

28-
await using var resultStream = await Http.GetStreamAsync(api + Uri.EscapeDataString(query), token: token).ConfigureAwait(false);
26+
await using var resultStream = await Main._context.API.HttpGetStreamAsync(api + Uri.EscapeDataString(query), token: token).ConfigureAwait(false);
2927

3028
using var json = await JsonDocument.ParseAsync(resultStream, cancellationToken: token);
3129

@@ -36,12 +34,12 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
3634
}
3735
catch (Exception e) when (e is HttpRequestException or {InnerException: TimeoutException})
3836
{
39-
Log.Exception("|DuckDuckGo.Suggestions|Can't get suggestion from DuckDuckGo", e);
37+
Main._context.API.LogException(nameof(DuckDuckGo), "Can't get suggestion from DuckDuckGo", e);
4038
return null;
4139
}
4240
catch (JsonException e)
4341
{
44-
Log.Exception("|DuckDuckGo.Suggestions|can't parse suggestions", e);
42+
Main._context.API.LogException(nameof(DuckDuckGo), "Can't parse suggestions", e);
4543
return new List<string>();
4644
}
4745
}

Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/Google.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
using System.Collections.Generic;
33
using System.Linq;
44
using System.Threading.Tasks;
5-
using Flow.Launcher.Infrastructure.Http;
6-
using Flow.Launcher.Infrastructure.Logger;
75
using System.Net.Http;
86
using System.Threading;
97
using System.Text.Json;
@@ -18,7 +16,7 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
1816
{
1917
const string api = "https://www.google.com/complete/search?output=chrome&q=";
2018

21-
await using var resultStream = await Http.GetStreamAsync(api + Uri.EscapeDataString(query), token: token).ConfigureAwait(false);
19+
await using var resultStream = await Main._context.API.HttpGetStreamAsync(api + Uri.EscapeDataString(query), token: token).ConfigureAwait(false);
2220

2321
using var json = await JsonDocument.ParseAsync(resultStream, cancellationToken: token);
2422

@@ -29,12 +27,12 @@ public override async Task<List<string>> SuggestionsAsync(string query, Cancella
2927
}
3028
catch (Exception e) when (e is HttpRequestException or {InnerException: TimeoutException})
3129
{
32-
Log.Exception("|Baidu.Suggestions|Can't get suggestion from baidu", e);
30+
Main._context.API.LogException(nameof(Google), "Can't get suggestion from baidu", e);
3331
return null;
3432
}
3533
catch (JsonException e)
3634
{
37-
Log.Exception("|Google.Suggestions|can't parse suggestions", e);
35+
Main._context.API.LogException(nameof(Google), "Can't parse suggestions", e);
3836
return new List<string>();
3937
}
4038
}

0 commit comments

Comments
 (0)