Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify building process #256

Closed
radeno opened this issue Oct 6, 2018 · 2 comments
Closed

Simplify building process #256

radeno opened this issue Oct 6, 2018 · 2 comments

Comments

@radeno
Copy link
Contributor

radeno commented Oct 6, 2018

Hello,

thanks for this great module for React Native, but without published newest beta in NPM i have been forced to build it by own.
Never worked with Typescript before so this was most caveats what i met.

  1. Include all necessary dependencies into package.json
    Remove setup.sh script and add all dependencies as devDependencies it is more automatized to build package
    "file-directives": "^1.4.6",
    "tslint": "^5.11.0",
    "typescript": "^3.1.1"
  1. Add needed types to tsconfig.json
    Just add types dependecies: "types": ["react", "react-native"]
  2. dom library in tsconfig.json is conflicting with react native because Geolocation is defined in DOM and React-Native as same.
    need to skip library checking in tsconfig.json
    "skipLibCheck": true

Then i was able to build whole package just with one command npm run build and it works seamsless.

@radeno
Copy link
Contributor Author

radeno commented Oct 7, 2018

PR #257

@radeno
Copy link
Contributor Author

radeno commented Oct 9, 2018

Merged

@radeno radeno closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant