Skip to content

Commit d33a1ac

Browse files
fix(core): Assign properties.success earlier to set executionStatus correctly (n8n-io#5773)
assign properties.success earlier
1 parent e67ad29 commit d33a1ac

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/cli/src/InternalHooks.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,8 @@ export class InternalHooks implements IInternalHooksClass {
284284
properties.user_id = userId;
285285
}
286286

287+
properties.success = !!runData?.finished;
288+
287289
let executionStatus: ExecutionStatus;
288290
if (runData?.status === 'crashed') {
289291
executionStatus = 'crashed';
@@ -295,7 +297,6 @@ export class InternalHooks implements IInternalHooksClass {
295297

296298
if (runData !== undefined) {
297299
properties.execution_mode = runData.mode;
298-
properties.success = !!runData.finished;
299300
properties.is_manual = runData.mode === 'manual';
300301

301302
let nodeGraphResult: INodesGraphResult | null = null;

0 commit comments

Comments
 (0)