improve metadata type

Author: khvn26

flagsmith/models.py

@@ -30,14 +30,12 @@ def from_evaluation_result(
         cls,
         flag_result: SDKFlagResult,
     ) -> typing.Optional[Flag]:
-        if (
-            flagsmith_id := (flag_result.get("metadata") or {}).get("flagsmith_id")
-        ) is not None:
+        if metadata := flag_result.get("metadata"):
             return Flag(
                 enabled=flag_result["enabled"],
                 value=flag_result["value"],
                 feature_name=flag_result["name"],
-                feature_id=flagsmith_id,
+                feature_id=metadata["flagsmith_id"],
             )
         return None
 

flagsmith/types.py

@@ -45,7 +45,7 @@ class SegmentMetadata(typing.TypedDict):
 
 
 class FeatureMetadata(typing.TypedDict):
-    flagsmith_id: NotRequired[int]
+    flagsmith_id: int
     """The ID of the feature used in Flagsmith API."""