Skip to content

Commit 8bfe029

Browse files
committed
improve test
1 parent fdc89d6 commit 8bfe029

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

tests/test_models.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,10 @@ def test_flags_from_evaluation_result(
115115
)
116116

117117
# Then
118-
assert len(flags.flags) == len(expected_names)
119-
120-
for name in expected_names:
121-
assert name in flags.flags
122-
flag: Flag = flags.flags[name]
123-
assert isinstance(flag, Flag)
124-
assert flag.feature_name == name
118+
assert set(flags.flags.keys()) == set(expected_names)
119+
assert set(flag.feature_name for flag in flags.flags.values()) == set(
120+
expected_names
121+
)
125122

126123

127124
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)