Skip to content

Commit 60e244f

Browse files
committed
deps: Bump flagsmith-flag-engine from 7.0.0 to 8.0.0
1 parent 1c7e8c9 commit 60e244f

File tree

5 files changed

+39
-28
lines changed

5 files changed

+39
-28
lines changed

flagsmith/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ def from_evaluation_result(
6363
) -> Flags:
6464
return cls(
6565
flags={
66-
flag["name"]: Flag(
66+
flag_name: Flag(
6767
enabled=flag["enabled"],
6868
value=flag["value"],
6969
feature_name=flag["name"],
7070
feature_id=int(flag["feature_key"]),
7171
)
72-
for flag in evaluation_result["flags"]
72+
for flag_name, flag in evaluation_result["flags"].items()
7373
},
7474
default_flag_handler=default_flag_handler,
7575
_analytics_processor=analytics_processor,

poetry.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ packages = [{ include = "flagsmith" }]
1313
python = ">=3.9,<4"
1414
requests = "^2.32.3"
1515
requests-futures = "^1.0.1"
16-
flagsmith-flag-engine = "^7.0.0"
16+
flagsmith-flag-engine = "^8.0.0"
1717
sseclient-py = "^1.8.0"
1818

1919
[tool.poetry.group.dev]

tests/test_flagsmith.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,14 +159,14 @@ def test_get_identity_flags_uses_local_environment_when_available(
159159
mock_engine = mocker.patch("flagsmith.flagsmith.engine")
160160

161161
expected_evaluation_result = {
162-
"flags": [
163-
{
162+
"flags": {
163+
"some_feature": {
164164
"name": "some_feature",
165165
"enabled": True,
166166
"value": "some-feature-state-value",
167167
"feature_key": "1",
168168
}
169-
],
169+
},
170170
"segments": [],
171171
}
172172

tests/test_models.py

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,55 +29,66 @@ def test_flag_from_evaluation_result() -> None:
2929
@pytest.mark.parametrize(
3030
"flags_result,expected_count,expected_names",
3131
[
32-
([], 0, []),
32+
({}, 0, []),
3333
(
34-
[
35-
{
34+
{
35+
"feature1": {
3636
"name": "feature1",
3737
"enabled": True,
3838
"value": "value1",
3939
"feature_key": "1",
4040
}
41-
],
41+
},
4242
1,
4343
["feature1"],
4444
),
4545
(
46-
[
47-
{
46+
{
47+
"feature1": {
48+
"name": "feature1",
49+
"enabled": True,
50+
"value": "value1",
51+
"feature_key": "1",
52+
}
53+
},
54+
1,
55+
["feature1"],
56+
),
57+
(
58+
{
59+
"feature1": {
4860
"name": "feature1",
4961
"enabled": True,
5062
"value": "value1",
5163
"feature_key": "1",
5264
},
53-
{
65+
"feature2": {
5466
"name": "feature2",
55-
"enabled": False,
56-
"value": None,
67+
"enabled": True,
68+
"value": "value2",
5769
"feature_key": "2",
5870
},
59-
{"name": "feature3", "enabled": True, "value": 42, "feature_key": "3"},
60-
],
71+
"feature3": {
72+
"name": "feature3",
73+
"enabled": True,
74+
"value": 42,
75+
"feature_key": "3",
76+
},
77+
},
6178
3,
6279
["feature1", "feature2", "feature3"],
6380
),
6481
],
6582
)
6683
def test_flags_from_evaluation_result(
67-
flags_result: typing.List[FlagResult],
84+
flags_result: typing.Dict[str, FlagResult],
6885
expected_count: int,
6986
expected_names: typing.List[str],
7087
) -> None:
7188
# Given
7289
evaluation_result: EvaluationResult = {
7390
"flags": flags_result,
7491
"segments": [],
75-
"context": {
76-
"environment": {
77-
"name": "test_environment",
78-
"key": "test_environment_key",
79-
}
80-
},
8192
}
8293

8394
# When

0 commit comments

Comments
 (0)