Use default flags in local evaluation mode #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
force-pushed
the
105-provided-default-flags-should-be-used-when-unable-to-establish-connectivity-to-flagsmith-api
branch
5 times, most recently
from
6bf8ce7 to
d8b5991
Compare
gagantrivedi
approved these changes
Mar 27, 2023
pom.xml
Outdated
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> | ||
| <version>7.6.1</version> | ||
| <version>7.5</version> |
Member
There was a problem hiding this comment.
Does that mean we downgraded some external module named testing?
Contributor
Author
There was a problem hiding this comment.
Yeah, I had to do this to get the test runner working in VSCode. Although, I believe I actually need to rebase as that should be fixed here instead: a7df658
matthewelwell
force-pushed
the
105-provided-default-flags-should-be-used-when-unable-to-establish-connectivity-to-flagsmith-api
branch
from
d8b5991 to
286f62a
Compare
matthewelwell
commented
Mar 27, 2023
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> | ||
| <version>7.6.1</version> |
Contributor
Author
There was a problem hiding this comment.
This was removed as it's a duplicate of this.
Contributor
Author
|
Tests here should be fixed by #112 |
…efault-flags-should-be-used-when-unable-to-establish-connectivity-to-flagsmith-api
matthewelwell
deleted the
105-provided-default-flags-should-be-used-when-unable-to-establish-connectivity-to-flagsmith-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves 2 things: