Skip to content

Commit b888c51

Browse files
aboganikuba-moo
authored andcommitted
igb: Avoid starting unnecessary workqueues
If ptp_clock_register() fails or CONFIG_PTP isn't enabled, avoid starting PTP related workqueues. In this way we can fix this: BUG: unable to handle page fault for address: ffffc9000440b6f8 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 100000067 P4D 100000067 PUD 1001e0067 PMD 107dc5067 PTE 0 Oops: 0000 [#1] PREEMPT SMP [...] Workqueue: events igb_ptp_overflow_check RIP: 0010:igb_rd32+0x1f/0x60 [...] Call Trace: igb_ptp_read_82580+0x20/0x50 timecounter_read+0x15/0x60 igb_ptp_overflow_check+0x1a/0x50 process_one_work+0x1cb/0x3c0 worker_thread+0x53/0x3f0 ? rescuer_thread+0x370/0x370 kthread+0x142/0x160 ? kthread_associate_blkcg+0xc0/0xc0 ret_from_fork+0x1f/0x30 Fixes: 1f6e817 ("igb: Prevent dropped Tx timestamps via work items and interrupts.") Fixes: d339b13 ("igb: add PTP Hardware Clock code") Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu> Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20230821171927.2203644-1-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9536c2f commit b888c51

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/net/ethernet/intel/igb/igb_ptp.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,18 +1385,6 @@ void igb_ptp_init(struct igb_adapter *adapter)
13851385
return;
13861386
}
13871387

1388-
spin_lock_init(&adapter->tmreg_lock);
1389-
INIT_WORK(&adapter->ptp_tx_work, igb_ptp_tx_work);
1390-
1391-
if (adapter->ptp_flags & IGB_PTP_OVERFLOW_CHECK)
1392-
INIT_DELAYED_WORK(&adapter->ptp_overflow_work,
1393-
igb_ptp_overflow_check);
1394-
1395-
adapter->tstamp_config.rx_filter = HWTSTAMP_FILTER_NONE;
1396-
adapter->tstamp_config.tx_type = HWTSTAMP_TX_OFF;
1397-
1398-
igb_ptp_reset(adapter);
1399-
14001388
adapter->ptp_clock = ptp_clock_register(&adapter->ptp_caps,
14011389
&adapter->pdev->dev);
14021390
if (IS_ERR(adapter->ptp_clock)) {
@@ -1406,6 +1394,18 @@ void igb_ptp_init(struct igb_adapter *adapter)
14061394
dev_info(&adapter->pdev->dev, "added PHC on %s\n",
14071395
adapter->netdev->name);
14081396
adapter->ptp_flags |= IGB_PTP_ENABLED;
1397+
1398+
spin_lock_init(&adapter->tmreg_lock);
1399+
INIT_WORK(&adapter->ptp_tx_work, igb_ptp_tx_work);
1400+
1401+
if (adapter->ptp_flags & IGB_PTP_OVERFLOW_CHECK)
1402+
INIT_DELAYED_WORK(&adapter->ptp_overflow_work,
1403+
igb_ptp_overflow_check);
1404+
1405+
adapter->tstamp_config.rx_filter = HWTSTAMP_FILTER_NONE;
1406+
adapter->tstamp_config.tx_type = HWTSTAMP_TX_OFF;
1407+
1408+
igb_ptp_reset(adapter);
14091409
}
14101410
}
14111411

0 commit comments

Comments
 (0)