@@ -221,7 +221,7 @@ struct devlink_dpipe_field {
221221/**
222222 * struct devlink_dpipe_header - dpipe header object
223223 * @name: header name
224- * @id: index, global/local detrmined by global bit
224+ * @id: index, global/local determined by global bit
225225 * @fields: fields
226226 * @fields_count: number of fields
227227 * @global: indicates if header is shared like most protocol header
@@ -241,7 +241,7 @@ struct devlink_dpipe_header {
241241 * @header_index: header index (packets can have several headers of same
242242 * type like in case of tunnels)
243243 * @header: header
244- * @fieled_id : field index
244+ * @field_id : field index
245245 */
246246struct devlink_dpipe_match {
247247 enum devlink_dpipe_match_type type ;
@@ -256,7 +256,7 @@ struct devlink_dpipe_match {
256256 * @header_index: header index (packets can have several headers of same
257257 * type like in case of tunnels)
258258 * @header: header
259- * @fieled_id : field index
259+ * @field_id : field index
260260 */
261261struct devlink_dpipe_action {
262262 enum devlink_dpipe_action_type type ;
@@ -292,7 +292,7 @@ struct devlink_dpipe_value {
292292 * struct devlink_dpipe_entry - table entry object
293293 * @index: index of the entry in the table
294294 * @match_values: match values
295- * @matche_values_count : count of matches tuples
295+ * @match_values_count : count of matches tuples
296296 * @action_values: actions values
297297 * @action_values_count: count of actions values
298298 * @counter: value of counter
@@ -342,7 +342,9 @@ struct devlink_dpipe_table_ops;
342342 */
343343struct devlink_dpipe_table {
344344 void * priv ;
345+ /* private: */
345346 struct list_head list ;
347+ /* public: */
346348 const char * name ;
347349 bool counters_enabled ;
348350 bool counter_control_extern ;
@@ -355,13 +357,13 @@ struct devlink_dpipe_table {
355357
356358/**
357359 * struct devlink_dpipe_table_ops - dpipe_table ops
358- * @actions_dump - dumps all tables actions
359- * @matches_dump - dumps all tables matches
360- * @entries_dump - dumps all active entries in the table
361- * @counters_set_update - when changing the counter status hardware sync
360+ * @actions_dump: dumps all tables actions
361+ * @matches_dump: dumps all tables matches
362+ * @entries_dump: dumps all active entries in the table
363+ * @counters_set_update: when changing the counter status hardware sync
362364 * maybe needed to allocate/free counter related
363365 * resources
364- * @size_get - get size
366+ * @size_get: get size
365367 */
366368struct devlink_dpipe_table_ops {
367369 int (* actions_dump )(void * priv , struct sk_buff * skb );
@@ -374,8 +376,8 @@ struct devlink_dpipe_table_ops {
374376
375377/**
376378 * struct devlink_dpipe_headers - dpipe headers
377- * @headers - header array can be shared (global bit) or driver specific
378- * @headers_count - count of headers
379+ * @headers: header array can be shared (global bit) or driver specific
380+ * @headers_count: count of headers
379381 */
380382struct devlink_dpipe_headers {
381383 struct devlink_dpipe_header * * headers ;
@@ -387,7 +389,7 @@ struct devlink_dpipe_headers {
387389 * @size_min: minimum size which can be set
388390 * @size_max: maximum size which can be set
389391 * @size_granularity: size granularity
390- * @size_unit : resource's basic unit
392+ * @unit : resource's basic unit
391393 */
392394struct devlink_resource_size_params {
393395 u64 size_min ;
@@ -457,6 +459,7 @@ struct devlink_flash_notify {
457459
458460/**
459461 * struct devlink_param - devlink configuration parameter data
462+ * @id: devlink parameter id number
460463 * @name: name of the parameter
461464 * @generic: indicates if the parameter is generic or driver specific
462465 * @type: parameter type
@@ -632,6 +635,7 @@ enum devlink_param_generic_id {
632635 * struct devlink_flash_update_params - Flash Update parameters
633636 * @fw: pointer to the firmware data to update from
634637 * @component: the flash component to update
638+ * @overwrite_mask: which types of flash update are supported (may be %0)
635639 *
636640 * With the exception of fw, drivers must opt-in to parameters by
637641 * setting the appropriate bit in the supported_flash_update_params field in
0 commit comments