Skip to content

Test behavior using only job.environment configuration #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Aug 11, 2021

No description provided.

@Firehed Firehed had a problem deploying to dev-refs/pull/4/merge August 11, 2021 22:00 Failure
@github-actions github-actions bot requested a deployment to production August 11, 2021 22:00 Pending
@Firehed Firehed temporarily deployed to dev-refs/pull/4/merge August 11, 2021 22:01 Inactive
@github-actions github-actions bot temporarily deployed to production August 11, 2021 22:01 Inactive
@Firehed Firehed temporarily deployed to dev-refs/pull/4/merge August 11, 2021 22:10 Inactive
@github-actions github-actions bot temporarily deployed to production August 11, 2021 22:10 Inactive
@Firehed Firehed closed this Aug 12, 2021
@Firehed Firehed deleted the test-base-env branch August 12, 2021 16:05
@Firehed Firehed restored the test-base-env branch August 12, 2021 16:35
@Firehed Firehed reopened this Aug 12, 2021
@Firehed Firehed temporarily deployed to dev-refs/pull/4/merge August 12, 2021 16:35 Inactive
@github-actions github-actions bot temporarily deployed to production August 12, 2021 16:35 Inactive
@Firehed Firehed deployed to dev-refs/pull/4/merge August 12, 2021 16:35 Active
@github-actions github-actions bot temporarily deployed to production August 12, 2021 16:35 Inactive
@Firehed
Copy link
Owner Author

Firehed commented Aug 12, 2021

Learnings here: there's (as of writing) completely undocumented behavior that if you use the workflow environments feature (jobs.id.environment), it will automatically create and update the status of a deployment.

https://github.community/t/using-github-actions-environments-without-creating-deployment/168426

While it would be ideal to hook into there (both pragmatically and to benefit from stuff like secret management), nothing I've seen looking through the logs makes it appear accessible in any practical way, and it seems to lead to conflicts more often than not.

At least until the features and/or API mature, I think it's necessary to recommend avoiding the feature in combination with this action for now. If it becomes possible to use the created deployment and take over its status updates, I'll re-evaluate that position; ideally, it would actually be the default behavior (which would probably necessitate a breaking change)

@Firehed Firehed closed this Aug 12, 2021
@Firehed Firehed deleted the test-base-env branch August 12, 2021 16:47
@Firehed Firehed changed the title Try dummy step Test behavior using only job.environment configuration Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant