Skip to content

Fixes for PHPUnit 8 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 12, 2019
Merged

Fixes for PHPUnit 8 #94

merged 11 commits into from
Feb 12, 2019

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Feb 4, 2019

No description provided.

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #94 into 3_2_0 will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##              3_2_0      #94      +/-   ##
============================================
- Coverage     96.06%   96.01%   -0.06%     
+ Complexity      119      114       -5     
============================================
  Files            26       26              
  Lines           356      351       -5     
============================================
- Hits            342      337       -5     
  Misses           14       14
Impacted Files Coverage Δ Complexity Δ
src/Traits/EndpointTestCases.php 93.93% <100%> (-0.51%) 9 <0> (-2)
src/Config.php 97.14% <0%> (-0.08%) 16% <0%> (-2%)
src/Dispatcher.php 98.47% <0%> (-0.02%) 44% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0a045...f5e3c5e. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #94 into 3_2_0 will decrease coverage by 5.13%.
The diff coverage is 4.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##              3_2_0      #94      +/-   ##
============================================
- Coverage     96.06%   90.93%   -5.14%     
- Complexity      119      128       +9     
============================================
  Files            26       29       +3     
  Lines           356      375      +19     
============================================
- Hits            342      341       -1     
- Misses           14       34      +20
Impacted Files Coverage Δ Complexity Δ
src/Traits/Testing/PHPUnit8ShimPHPLT71.php 0% <0%> (ø) 3 <3> (?)
src/Traits/Testing/PHPUnit8ShimPHPGTE71.php 0% <0%> (ø) 6 <6> (?)
src/Traits/Testing/PHPUnit8Shim.php 0% <0%> (ø) 0 <0> (?)
src/Traits/EndpointTestCases.php 94.28% <100%> (-0.16%) 11 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0a045...9a5b7e2. Read the comment docs.

@Firehed
Copy link
Owner Author

Firehed commented Feb 12, 2019

This is all kinds of dumb, but should actually resolve the issue.

@Firehed Firehed merged commit c4a3fa7 into 3_2_0 Feb 12, 2019
@Firehed Firehed deleted the fix_phpunit_8 branch February 12, 2019 22:15
@Firehed Firehed mentioned this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant