ODS14: header page refactoring #8401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dyemanov
commented
Jan 20, 2025
dyemanov
commented
- Make transaction/attachment counters natively 64-bit
- Refactor backup/shutdown/replica flags into dedicated modes
- Move GUID to the core part of the header
- Cleanup the remaining stuff from multi-file databases
- Some other misc changes
…ility between 32-bit and 64-bit builds spotted by the CI workflow.
|
Apparently #8340 also has an alignment issue for 32-bit builds. |
Yes, it will be fixed too. |
AlexPeshkoff
pushed a commit
that referenced
this pull request
May 30, 2025
* Make counters natively 64-bit, simplify the related code * Group implementation bytes together * Refactor backup/shutdown/replica flags into dedicated modes * Misc cleanup * Misc * Move database GUID to the core header part * A bit denser header layout. This also should fix alignment incompatibility between 32-bit and 64-bit builds spotted by the CI workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.