Added shutdown handler for Classic Server #8165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -314,6 +315,10 @@ int CLIB_ROUTINE main( int argc, char** argv) | |||
| // activate paths set with -e family of switches | |||
| ISC_set_prefix(0, 0); | |||
|
|
|||
| // set shutdown signals handler for listener | |||
There was a problem hiding this comment.
Does it make sense to add this handlers in super & superclassic modes?
There was a problem hiding this comment.
No, it's only relevant to classic
There was a problem hiding this comment.
I'll add a condition
|
Alex, any other suggestions or is it OK for merging? |
AlexPeshkoff
approved these changes
Jul 8, 2024
|
I suggest to backport it to 5 & 4. |
dyemanov
pushed a commit
that referenced
this pull request
Jul 10, 2024
Co-authored-by: Alexander Zhdanov <alexander.zhdanov@red-soft.ru>
dyemanov
pushed a commit
that referenced
this pull request
Jul 10, 2024
Co-authored-by: Alexander Zhdanov <alexander.zhdanov@red-soft.ru>
|
Backported. |
dyemanov
changed the title
dyemanov
pushed a commit
that referenced
this pull request
Nov 16, 2024
Co-authored-by: Alexander Zhdanov <alexander.zhdanov@red-soft.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shutdown handler for server to avoid active connections after termination.
If you start the server with classic mode, then at the end of the server, there are still active connections.