Improvement #7692 : Make trace config parser resolve symlinks in database file path in trace configuration #7693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base file path in trace configuration
AlexPeshkoff
approved these changes
Aug 2, 2023
aafemt
reviewed
Aug 3, 2023
| expandDatabaseName(noQuotePattern, expandedName, nullptr) && | ||
| m_databaseName == expandedName) | ||
| (expandDatabaseName(noQuotePattern, expandedName, nullptr), | ||
| m_databaseName == expandedName) ) |
There was a problem hiding this comment.
Why would you like to compare m_databaseName with garbage in expandedName if expandDatabaseName() failed?
There was a problem hiding this comment.
"false" returned by expandDatabaseName does not mean that we got garbage in expandedName. It just reports that alias was not found in databases.conf, rarely that info is (or 'was' - not sure for today) needed to the caller.
There was a problem hiding this comment.
expandedName always contains the most correct name of DB file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.