Skip to content

Commit 923debd

Browse files
committed
Backport feature #8273 - Reorganize public headers.
Merge branch 'work/public-headers-v5' into v5.0-release
2 parents fc48aa2 + eb7be8b commit 923debd

File tree

16 files changed

+1353
-1276
lines changed

16 files changed

+1353
-1276
lines changed

builds/install/arch-specific/solaris/CS/prototype.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ s none /usr/lib/libfbclient.so.2=@prefix@/lib/libfbclient.so.2
3838

3939
d none @prefix@/include 0751 firebird firebird
4040
f none @prefix@/include/ib_util.h=$SRCDIR/include/ib_util.h 0444 firebird firebird
41-
f none @prefix@/include/perf.h=$SRCDIR/include/perf.h 0444 firebird firebird
4241
f none @prefix@/include/iberror.h=$SRCDIR/include/iberror.h 0444 firebird firebird
4342
f none @prefix@/include/ibase.h=$SRCDIR/include/ibase.h 0444 firebird firebird
4443

builds/install/arch-specific/solaris/SS/prototype.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ s none /usr/lib/libfbclient.so.2=@prefix@/lib/libfbclient.so.2
3838

3939
d none @prefix@/include 0755 firebird firebird
4040
f none @prefix@/include/ib_util.h=$SRCDIR/include/ib_util.h 0644 firebird firebird
41-
f none @prefix@/include/perf.h=$SRCDIR/include/perf.h 0644 firebird firebird
4241
f none @prefix@/include/iberror.h=$SRCDIR/include/iberror.h 0644 firebird firebird
4342
f none @prefix@/include/ibase.h=$SRCDIR/include/ibase.h 0644 firebird firebird
4443

builds/install/arch-specific/solx86gcc/CS/prototype.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ f none @prefix@/include/blr.h=$SRCDIR/include/blr.h 0644 root root
108108
f none @prefix@/include/ib_util.h=$SRCDIR/include/ib_util.h 0644 root root
109109
f none @prefix@/include/ibase.h=$SRCDIR/include/ibase.h 0644 root root
110110
f none @prefix@/include/iberror.h=$SRCDIR/include/iberror.h 0644 root root
111-
f none @prefix@/include/perf.h=$SRCDIR/include/perf.h 0644 root root
112111

113112
d none @prefix@/intl 0755 root root
114113
f none @prefix@/intl/libfbintl.so=$SRCDIR/intl/libfbintl.so 0755 root root

builds/install/arch-specific/win32/BuildExecutableInstall.bat

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,12 +397,10 @@ for %%v in (IPLicense.txt IDPLicense.txt ) do (
397397
:: grab some missing bits'n'pieces from different parts of the source tree
398398
::=========================================================================
399399
@echo Copying ib_util etc
400-
@copy %FB_ROOT_PATH%\src\extlib\ib_util.h %FB_OUTPUT_DIR%\include > nul || (call :ERROR Copying ib_util.h failed. & goto :EOF )
401400
@copy %FB_ROOT_PATH%\src\misc\pascal\ib_util.pas %FB_OUTPUT_DIR%\include > nul || (call :ERROR Copying ib_util.pas failed. & goto :EOF )
402401

403402
@echo Copying other include files required for development...
404403
@set OUTPATH=%FB_OUTPUT_DIR%\include
405-
@copy %FB_ROOT_PATH%\src\yvalve\perf.h %OUTPATH%\ > nul
406404
@copy %FB_ROOT_PATH%\src\include\gen\firebird.pas %OUTPATH%\firebird\ > nul || (@call :ERROR Failure executing copy %FB_ROOT_PATH%\src\include\gen\firebird.pas %OUTPATH%\firebird\ )
407405
@if ERRORLEVEL 1 goto :END
408406

builds/posix/Makefile.in

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -740,20 +740,13 @@ gbak_files: $(GBAK_FILES)
740740

741741
INCLUDE_DEST= $(FB_BUILD)/include
742742

743-
NEW_INCLUDES_SRC = $(shell find $(SRC_ROOT)/include/firebird -type f)
744-
NEW_INCLUDES_DEST = $(patsubst $(SRC_ROOT)/include/firebird/%, $(INCLUDE_DEST)/firebird/%, $(NEW_INCLUDES_SRC))
745-
746-
include_generic: $(INCLUDE_DEST)/ib_util.h \
747-
$(NEW_INCLUDES_DEST)
748-
749743
# ib_util.h actually is a marker for a number of headers
750744

751745
# Copy all the other headers to the distribution directory. We use
752746
# ib_util.h as the marker for all the files.
753747

754-
OtherDistribHeaders = extlib/ib_util.h \
755-
yvalve/perf.h \
756-
include/iberror.h \
748+
OtherDistribHeaders = include/ib_util.h \
749+
include/iberror.h \
757750
include/ibase.h
758751

759752
SRC_OtherDistribHeaders = $(addprefix $(SRC_ROOT)/, $(OtherDistribHeaders))
@@ -762,6 +755,11 @@ $(INCLUDE_DEST)/ib_util.h : $(SRC_OtherDistribHeaders)
762755
mkdir -p $(INCLUDE_DEST)
763756
$(CP) $^ $(INCLUDE_DEST)/
764757

758+
NEW_INCLUDES_SRC = $(shell find $(SRC_ROOT)/include/firebird -type f)
759+
NEW_INCLUDES_DEST = $(patsubst $(SRC_ROOT)/include/firebird/%, $(INCLUDE_DEST)/firebird/%, $(NEW_INCLUDES_SRC))
760+
761+
include_generic: $(NEW_INCLUDES_DEST) $(INCLUDE_DEST)/ib_util.h
762+
765763
ifeq ($(SYSTEM_BOOST_FLG),Y)
766764
$(INCLUDE_DEST)/firebird/Message.h : $(SRC_ROOT)/include/firebird/Message.h
767765
sed 's,^#include "\./impl/boost/\(.\+\)",#include <boost/\1>,; s/\bFB_BOOST_PP_/BOOST_PP_/g' $< > $@

builds/win32/make_all.bat

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ for %%v in (gpre_boot build_msg common_test engine_test) do (
9696
)
9797

9898
:: Headers
99-
copy %FB_ROOT_PATH%\src\extlib\ib_util.h %FB_OUTPUT_DIR%\include > nul
100-
copy %FB_ROOT_PATH%\src\jrd\perf.h %FB_OUTPUT_DIR%\include >nul
10199
copy %FB_ROOT_PATH%\src\include\ibase.h %FB_OUTPUT_DIR%\include > nul
102100
copy %FB_ROOT_PATH%\src\include\iberror.h %FB_OUTPUT_DIR%\include > nul
103101
copy %FB_GEN_DIR%\iberror_c.h %FB_OUTPUT_DIR%\include\firebird\impl > nul

builds/win32/msvc15/ib_util.vcxproj

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,6 @@
192192
<ItemGroup>
193193
<ClCompile Include="..\..\..\src\extlib\ib_util.cpp" />
194194
</ItemGroup>
195-
<ItemGroup>
196-
<ClInclude Include="..\..\..\src\extlib\ib_util.h" />
197-
</ItemGroup>
198195
<ItemGroup>
199196
<ResourceCompile Include="..\..\..\src\jrd\version.rc">
200197
<AdditionalIncludeDirectories Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">..\..\..\src\jrd</AdditionalIncludeDirectories>
@@ -209,4 +206,4 @@
209206
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
210207
<ImportGroup Label="ExtensionTargets">
211208
</ImportGroup>
212-
</Project>
209+
</Project>

builds/win32/msvc15/ib_util.vcxproj.filters

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@
1818
<Filter>EXTLIB files</Filter>
1919
</ClCompile>
2020
</ItemGroup>
21-
<ItemGroup>
22-
<ClInclude Include="..\..\..\src\extlib\ib_util.h">
23-
<Filter>Header files</Filter>
24-
</ClInclude>
25-
</ItemGroup>
2621
<ItemGroup>
2722
<ResourceCompile Include="..\..\..\src\jrd\version.rc">
2823
<Filter>Resource files</Filter>
@@ -31,4 +26,4 @@
3126
<ItemGroup>
3227
<None Include="..\defs\ib_util.def" />
3328
</ItemGroup>
34-
</Project>
29+
</Project>

examples/udf/udflib.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
#endif
3636
#include <string.h>
3737
#include <math.h>
38-
#include <ibase.h>
38+
#include "firebird/ibase.h"
3939
#include "example.h"
40-
#include "ib_util.h"
40+
#include "firebird/ib_util.h"
4141

4242
#define BADVAL -9999L
4343
#define MYBUF_LEN 15 /* number of chars to get for */

src/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ set_output_directory (intl intl)
527527
# SHARED LIBRARY ib_util
528528
########################################
529529

530-
add_library (ib_util SHARED extlib/ib_util.cpp extlib/ib_util.h ${VERSION_RC})
530+
add_library (ib_util SHARED extlib/ib_util.cpp ${VERSION_RC})
531531
set_exported_symbols (ib_util ib_util)
532532
set_output_directory_unix (ib_util lib)
533533

@@ -904,9 +904,7 @@ add_custom_target(copy_files
904904
COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_SOURCE_DIR}/examples/stat ${output_dir}/examples/stat
905905
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/examples/functions.c ${output_dir}/examples/functions.c
906906
# headers
907-
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/src/extlib/ib_util.h ${output_dir}/include/ib_util.h
908907
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/src/include/gen/iberror.h ${output_dir}/include/iberror.h
909-
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/src/yvalve/perf.h ${output_dir}/include/perf.h
910908
)
911909
add_dependencies_cc (copy_files databases)
912910
add_dependencies_unix_cc(copy_files makeHeader)

src/extlib/ib_util.h renamed to src/include/firebird/ib_util.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@
2121
* Contributor(s): ______________________________________.
2222
*/
2323

24-
#ifndef _IB_UTIL_H
25-
#define _IB_UTIL_H
24+
#ifndef FIREBIRD_IB_UTIL_H
25+
#define FIREBIRD_IB_UTIL_H
2626

2727
#ifdef __cplusplus
2828
extern "C" {
2929
#endif
3030

31-
extern void *ib_util_malloc(long);
31+
extern void* ib_util_malloc(long);
3232

3333
#ifdef __cplusplus
3434
} /* extern "C" */
3535
#endif
3636

37-
#endif /* _IB_UTIL_H */
37+
#endif /* FIREBIRD_IB_UTIL_H */

0 commit comments

Comments
 (0)