-
Notifications
You must be signed in to change notification settings - Fork 493
Report error when streaming loses connection. #179
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,8 +18,7 @@ FIREBASE_DIR=.. | |
GTEST_DIR=googletest/googletest | ||
ARDUINOJSON_DIR=../src/third-party/arduino-json-5.3 | ||
|
||
FIREBASE_SRCS=${FIREBASE_DIR}/src/FirebaseObject.cpp\ | ||
${FIREBASE_DIR}/src/FirebaseObject.h | ||
FIREBASE_SRCS=${FIREBASE_DIR}/src/FirebaseObject.cpp | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you have the .h here when you run "make clean" it deletes it. We also don't need it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ouch, maybe we should just have a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we are fine just leaving it out, it works this way. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep, the only gotcha is that it won't force to recompile if the .h changes. |
||
GTEST_SRCS=${GTEST_DIR}/src/gtest-all.cpp | ||
ARDUINOJSON_SRCS=${ARDUINOJSON_DIR}/src/JsonBuffer.cpp\ | ||
${ARDUINOJSON_DIR}/src/JsonObject.cpp\ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.