Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

Update to Ember 2.0 and Ember Data 2.0 and updates tests accordingly#310

Merged
tstirrat merged 15 commits into
FirebaseExtended:masterfrom
leifcr:update-test-dependencies
Sep 22, 2015
Merged

Update to Ember 2.0 and Ember Data 2.0 and updates tests accordingly#310
tstirrat merged 15 commits into
FirebaseExtended:masterfrom
leifcr:update-test-dependencies

Conversation

@leifcr
Copy link
Copy Markdown
Contributor

@leifcr leifcr commented Sep 2, 2015

To be able to fix issue #245, this PR updates tests and the dummy app to use Ember 2.0 and Ember Data 2.0

Testing on travis is re-enabled on all branches, to be able to commit/test branches before requesting a PR.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@leifcr
Copy link
Copy Markdown
Contributor Author

leifcr commented Sep 14, 2015

@googlebot I signed it!

Comment thread package.json Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this to a specific version, saves headaches later

@tstirrat
Copy link
Copy Markdown
Contributor

Thanks for this! 😎 I've been on vacation, so I haven't had a good chance to properly look at it until now.

@tstirrat tstirrat added this to the 2.0.0 Compat milestone Sep 15, 2015
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@leifcr
Copy link
Copy Markdown
Contributor Author

leifcr commented Sep 15, 2015

Thanks for looking at it!

Comment thread package.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do any necessary upgrades to bower.json/package.json that this ember-cli upgrade needed?

It looks like the removal of Brocfile.js was not needed anymore due to the upgrade, is this correct?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a siginifcant speed improvement on rebuild in 1.13.8. I'm seeing between 1 and 3 seconds rebuild time improvment here. Which saves time both for test and dev. And quite a few other fixes (https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md)

Brocfile.js is removed as stated in the transition document for ember-cli (https://github.com/ember-cli/ember-cli/blob/master/TRANSITION.md#brocfile-transition). It could have been removed in 1.13.0, but the deprecation message starts from 1.13.5.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just wanted to double check :)

@tstirrat
Copy link
Copy Markdown
Contributor

bummer, I guess it didn't like that. lets restore the resolution and I will merge.

@halfdan
Copy link
Copy Markdown
Contributor

halfdan commented Sep 22, 2015

Seems to be done ^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants