Update to Ember 2.0 and Ember Data 2.0 and updates tests accordingly#310
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
@googlebot I signed it! |
There was a problem hiding this comment.
Fix this to a specific version, saves headaches later
|
Thanks for this! 😎 I've been on vacation, so I haven't had a good chance to properly look at it until now. |
|
CLAs look good, thanks! |
|
Thanks for looking at it! |
There was a problem hiding this comment.
Did you do any necessary upgrades to bower.json/package.json that this ember-cli upgrade needed?
It looks like the removal of Brocfile.js was not needed anymore due to the upgrade, is this correct?
There was a problem hiding this comment.
Yes, there is a siginifcant speed improvement on rebuild in 1.13.8. I'm seeing between 1 and 3 seconds rebuild time improvment here. Which saves time both for test and dev. And quite a few other fixes (https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md)
Brocfile.js is removed as stated in the transition document for ember-cli (https://github.com/ember-cli/ember-cli/blob/master/TRANSITION.md#brocfile-transition). It could have been removed in 1.13.0, but the deprecation message starts from 1.13.5.
There was a problem hiding this comment.
Thanks, just wanted to double check :)
|
bummer, I guess it didn't like that. lets restore the resolution and I will merge. |
|
Seems to be done ^ |
To be able to fix issue #245, this PR updates tests and the dummy app to use Ember 2.0 and Ember Data 2.0
Testing on travis is re-enabled on all branches, to be able to commit/test branches before requesting a PR.