Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entryPoint option #16

Merged
merged 12 commits into from
Sep 9, 2020
Merged

Add entryPoint option #16

merged 12 commits into from
Sep 9, 2020

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented Sep 9, 2020

Fixes #16

Adds an entryPoint option to allow for firebase.json files that aren't in the repository's root.

The name entryPoint was chosen to feel similar to a workflow file's entrypoint, which doesn't work with JS Actions, but also maintain camel case to match the other options for this Action.

Example:

with:
repoToken: "${{ secrets.GITHUB_TOKEN }}"
firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}"
expires: 30d
projectId: action-hosting-deploy-demo
entryPoint: "./demo"

@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Deploy preview for 846da00:

https://action-hosting-deploy-demo--pr16-add-entrypoint-optio-daecu2og.web.app

(expires Wed, 16 Sep 2020 23:32:54 GMT)

firebase-hosting-preview-action

@googlebot googlebot added the cla: yes Contributor has signed CLA label Sep 9, 2020
@jhuleatt jhuleatt merged commit 577db06 into main Sep 9, 2020
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pomle pushed a commit to pomle/action-hosting-deploy that referenced this pull request Nov 8, 2020
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants