Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Passing of Build Parameters #387

Open
ChrisDeardeuff opened this issue Aug 14, 2024 · 0 comments
Open

Allow Passing of Build Parameters #387

ChrisDeardeuff opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ChrisDeardeuff
Copy link

The use case you're trying to solve

To my understanding from reading about similar problems, the project is rebuilt when firebase deploy is ran. This overrides any files that have been built before and thus ignores variables passed with --dart-define.

It would be nice to be able to specify '--dart-define var=value' parameters for building.

Change to the action that would solve that use case

Allow them to be passed in the ENV section of the yml. Example:

      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: ${{ secrets }}
          firebaseServiceAccount: ${{ secrets}}
          channelId: <channelid>
          projectId: <projectId>
        env:
         FIREBASE_CLI_EXPERIMENTS: webframeworks
         ADDITIONAL_BUILD_ARGS: --dart-define var=value --dart-define var2=value2

Other considerations

Possibly instead have a flag that stops the build process during deploy?

@ChrisDeardeuff ChrisDeardeuff added the enhancement New feature or request label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant