Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parser cannot parse event query when it includes double quote #773

Closed
tkxkd0159 opened this issue Jun 13, 2024 · 0 comments · Fixed by #774
Closed

Query parser cannot parse event query when it includes double quote #773

tkxkd0159 opened this issue Jun 13, 2024 · 0 comments · Fixed by #774
Labels
C: bug Classification: Something isn't working

Comments

@tkxkd0159
Copy link
Member

tkxkd0159 commented Jun 13, 2024

Ostracon version (use ostracon version or git rev-parse --verify HEAD if installed from source):

ABCI app (name for built-in, URL for self-written if it's publicly available):

Environment:

  • OS (e.g. from /etc/os-release):
  • Install tools:
  • Others:

What happened:
Finschia TypedEvent is unmarshalled by proto marhsaller. This marshaller add 0x22(") at both ends for some data (e.g. uint64, string). Finschia unmarshal this data by JSON unmarshaller and it lefts double quote in original data. (e.g. "1" instead of 1). So we need to query like lbm.fbridge.v1.EventTransfer.seq='\"1\"' but current query parser doesn't support this case.

What you expected to happen:

Have you tried the latest version: yes

How to reproduce it (as minimally and precisely as possible):
Generate TypedEvent and try to query using TxSearch

Logs (paste a small part showing an error (< 10 lines) or link a pastebin, gist, etc. containing more of the log file):

Config (you can paste only the changes you've made):

node command runtime flags:

Please provide the output from the http://<ip>:<port>/dump_consensus_state RPC endpoint for consensus bugs

Anything else we need to know:

@tkxkd0159 tkxkd0159 added the C: bug Classification: Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant