Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TODO: use base64.URLEncoding to modify TestQueryBlockByHash #711

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Oct 13, 2022

Description

relates: #699

Motivation and context

I found out how to fix TODO

How has this been tested?

By unit test code

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #711 (7382ed7) into main (fae516e) will increase coverage by 0.04%.
The diff coverage is 74.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   61.84%   61.88%   +0.04%     
==========================================
  Files         874      874              
  Lines       98557    98590      +33     
==========================================
+ Hits        60950    61011      +61     
+ Misses      33973    33948      -25     
+ Partials     3634     3631       -3     
Impacted Files Coverage Δ
client/rpc/block.go 46.55% <72.72%> (+34.64%) ⬆️
client/grpc/tmservice/service.go 68.75% <100.00%> (ø)
client/rpc/routes.go 100.00% <100.00%> (ø)
x/token/token.go 50.00% <0.00%> (-50.00%) ⬇️
x/token/msgs.go 30.45% <0.00%> (-4.07%) ⬇️
x/collection/collection.go 78.57% <0.00%> (-1.79%) ⬇️
x/collection/msgs.go 40.55% <0.00%> (-1.30%) ⬇️
x/wasm/keeper/keeper.go 86.16% <0.00%> (+0.36%) ⬆️
client/grpc/tmservice/query.pb.gw.go 32.14% <0.00%> (+4.48%) ⬆️
x/token/validation.go 90.90% <0.00%> (+18.18%) ⬆️
... and 1 more

@tkxkd0159
Copy link
Member

Ask questions to fully understand the context of the PR. Is it about preventing errors by making handlers instead of using gateway proxies?

@tnasu
Copy link
Member Author

tnasu commented Oct 13, 2022

@tkxkd0159 I've fixed this: https://github.com/line/lbm-sdk/blob/289ca6b2d11f988d6d45e28edf691511d2764209/client/grpc/tmservice/service_test.go

I haven't fixed this: #703

@tnasu tnasu self-assigned this Oct 13, 2022
@tnasu tnasu marked this pull request as ready for review October 13, 2022 06:34
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants