You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function defined as func (app *BaseApp) snapshot(height int64) does not return an error when the snapshot creation process fails. It silently handles the error without notifying the caller about it.
Snapshot Manager manages snapshot and restore operations for an app, making sure only a single long-running operation is in progress at any given time, and provides convenience methods mirroring the ABCI interface.
Version
Result
func (app *BaseApp) snapshot(height int64) is executed in ABCI Commit as goroutine. The success of commit should not depend on the success of snapshot functionality, so cosmos-sdk just records snapshot's error and return nothing. Because even we return error through go channel, there is nothing to do. So I will close this issue without fix.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
The function defined as
func (app *BaseApp) snapshot(height int64)
does not return an error when the snapshot creation process fails. It silently handles the error without notifying the caller about it.This function was moved at cosmos/cosmos-sdk#11496, osmosis-labs/cosmos-sdk#140. Snapshot functionality is managed through a manager pattern.
Version
Result
func (app *BaseApp) snapshot(height int64)
is executed in ABCI Commit as goroutine. The success of commit should not depend on the success of snapshot functionality, so cosmos-sdk just records snapshot's error and return nothing. Because even we return error through go channel, there is nothing to do. So I will close this issue without fix.For Admin Use
The text was updated successfully, but these errors were encountered: