Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v0.46.0-rc5 is incorrectly shown as rc2 #606

Closed
2 of 4 tasks
torao opened this issue Jul 22, 2022 · 1 comment
Closed
2 of 4 tasks

Version v0.46.0-rc5 is incorrectly shown as rc2 #606

torao opened this issue Jul 22, 2022 · 1 comment
Labels
A: bug Something isn't working

Comments

@torao
Copy link
Contributor

torao commented Jul 22, 2022

Summary of Bug

I checked out and built a commit 1bc3aac, which is tagged v0.46.0-rc5, then I got the version notation v0.46.0-rc2.

% simd version
0.46.0-rc2-178-g1bc3aac98

It should correctly say v0.46.0-rc5-XXX-g1bc3aac98.

Version

v0.46.0-rc5 (1bc3aac)

Steps to Reproduce

The following operation shows that v0.46.0-rc5 is checked out but the version number is replaced by v0.46.0-rc2 by make.

% git checkout v0.46.0-rc5

% make install
.. -X github.com/line/lbm-sdk/version.Version=0.46.0-rc2-178-g1bc3aac98 ..

% simd version
0.46.0-rc2-178-g1bc3aac98

The version number is obtained using git describe in Makefile#5. However, it seems to reference the v0.46.0-rc2 tag, even though the most recent tag is v0.46.0-rc5.

% git describe
v0.46.0-rc2-178-g1bc3aac98

% git describe --tag
v0.46.0-rc5

% git log --oneline
1bc3aac98 (HEAD -> v0.46.0-rc5, tag: v0.46.0-rc5, upstream/main) Remove prefetch functionality (#596)
c0ce87f0a feat: change amino codec path from `lbm-sdk/` to `cosmos-sdk/` (#600)
d4a8be2bc chore(deps): Bump github.com/spf13/cobra from 1.4.0 to 1.5.0 (#569)
...

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@torao torao added the A: bug Something isn't working label Jul 22, 2022
@zemyblue
Copy link
Member

zemyblue commented May 9, 2023

This is not a problem for now.

@zemyblue zemyblue closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants