Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend the unprocessed tx of mempool for a while #324

Closed
4 tasks
egonspace opened this issue Sep 13, 2021 · 1 comment
Closed
4 tasks

Resend the unprocessed tx of mempool for a while #324

egonspace opened this issue Sep 13, 2021 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@egonspace
Copy link

egonspace commented Sep 13, 2021

Summary of Bug

For some reason, a problem often arises in which txs remain in the full node's mempool receiving tx.
Once left, txs continue to remain in the mempool unless the node is restarted, causing an account sequence mismatch error.

This situation occurs because the message transmission to peer turns asynchronous and the messages are discarded when peer's receive buffer is full. (Finschia/ostracon#316)

If this issue(Finschia/ostracon#316) is resolved, this problem will rarely occur, but this problem will not be completely eliminated due to problems such as node and network failure.

Under normal circumstances, txs introduced into the mempool will propagate to the validator nodes, and txs will be removed from the mempool when they are contained in the block. However, for the above reason, the txs seem to remain undelivered to the validators.

To solve this problem, a mechanism is needed to retransmit tx that remains untreated in the mempool after a certain period of time.

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@egonspace egonspace changed the title Discard the unprocessed tx of mempool for a while Resend the unprocessed tx of mempool for a while Sep 13, 2021
@egonspace
Copy link
Author

Ostracon mempool is already implemented to re-send all tx in mempool.
We should investigate why validators don't include these txs in a proposal block.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant