refactor: remove unused MsgEmpty (#776)

* Remove MsgEmpty from proto * Remove related logic * Update CHANGELOG.md
Finschia · Nov 12, 2022 · 6792efe · 6792efe
1 parent 2357407
commit 6792efe
Show file tree

Hide file tree

Showing 12 changed files with 13 additions and 734 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 ### Features
 
 ### Improvements
+* (x/auth) [\#776](https://github.com/line/lbm-sdk/pull/776) remove unused MsgEmpty
 
 ### Bug Fixes
 * (x/foundation) [\#772](https://github.com/line/lbm-sdk/pull/772) export x/foundation pool

diff --git a/docs/core/proto-docs.md b/docs/core/proto-docs.md
@@ -26,12 +26,6 @@
 
     - [Query](#cosmos.auth.v1beta1.Query)
 
-- [cosmos/auth/v1beta1/tx.proto](#cosmos/auth/v1beta1/tx.proto)
-    - [MsgEmpty](#cosmos.auth.v1beta1.MsgEmpty)
-    - [MsgEmptyResponse](#cosmos.auth.v1beta1.MsgEmptyResponse)
-
-    - [Msg](#cosmos.auth.v1beta1.Msg)
-
 - [cosmos/authz/v1beta1/authz.proto](#cosmos/authz/v1beta1/authz.proto)
     - [GenericAuthorization](#cosmos.authz.v1beta1.GenericAuthorization)
     - [Grant](#cosmos.authz.v1beta1.Grant)
@@ -1598,57 +1592,6 @@ Since: cosmos-sdk 0.43 | GET|/cosmos/auth/v1beta1/accounts|
 
 
 
-<a name="cosmos/auth/v1beta1/tx.proto"></a>
-<p align="right"><a href="#top">Top</a></p>
-
-## cosmos/auth/v1beta1/tx.proto
-
-
-
-<a name="cosmos.auth.v1beta1.MsgEmpty"></a>
-
-### MsgEmpty
-MsgEmpty represents a message that doesn't do anything. Used to measure performance.
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| `from_address` | [string](#string) |  |  |
-
-
-
-
-
-
-<a name="cosmos.auth.v1beta1.MsgEmptyResponse"></a>
-
-### MsgEmptyResponse
-MsgEmptyResponse defines the Msg/Empty response type.
-
-
-
-
-
- <!-- end messages -->
-
- <!-- end enums -->
-
- <!-- end HasExtensions -->
-
-
-<a name="cosmos.auth.v1beta1.Msg"></a>
-
-### Msg
-Msg defines the auth Msg service.
-
-| Method Name | Request Type | Response Type | Description | HTTP Verb | Endpoint |
-| ----------- | ------------ | ------------- | ------------| ------- | -------- |
-| `Empty` | [MsgEmpty](#cosmos.auth.v1beta1.MsgEmpty) | [MsgEmptyResponse](#cosmos.auth.v1beta1.MsgEmptyResponse) | Empty defines a method that doesn't do anything. Used to measure performance. | |
-
- <!-- end services -->
-
-
-
 <a name="cosmos/authz/v1beta1/authz.proto"></a>
 <p align="right"><a href="#top">Top</a></p>
 

diff --git a/proto/cosmos/auth/v1beta1/tx.proto b/proto/cosmos/auth/v1beta1/tx.proto
diff --git a/x/auth/client/cli/tx.go b/x/auth/client/cli/tx.go
diff --git a/x/auth/keeper/msg_server.go b/x/auth/keeper/msg_server.go
diff --git a/x/auth/module.go b/x/auth/module.go
@@ -74,7 +74,7 @@ func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *r
 
 // GetTxCmd returns the root tx command for the auth module.
 func (AppModuleBasic) GetTxCmd() *cobra.Command {
-	return cli.NewTxCmd()
+	return nil
 }
 
 // GetQueryCmd returns the root query command for the auth module.
@@ -128,7 +128,6 @@ func (am AppModule) LegacyQuerierHandler(legacyQuerierCdc *codec.LegacyAmino) sd
 // RegisterServices registers a GRPC query service to respond to the
 // module-specific GRPC queries.
 func (am AppModule) RegisterServices(cfg module.Configurator) {
-	types.RegisterMsgServer(cfg.MsgServer(), keeper.NewMsgServerImpl(am.accountKeeper))
 	types.RegisterQueryServer(cfg.QueryServer(), am.accountKeeper)
 
 	// m := keeper.NewMigrator(am.accountKeeper)

diff --git a/x/auth/types/codec.go b/x/auth/types/codec.go
@@ -5,7 +5,6 @@ import (
 	"github.com/line/lbm-sdk/codec/types"
 	cryptocodec "github.com/line/lbm-sdk/crypto/codec"
 	sdk "github.com/line/lbm-sdk/types"
-	"github.com/line/lbm-sdk/types/msgservice"
 	"github.com/line/lbm-sdk/x/auth/legacy/legacytx"
 	authzcodec "github.com/line/lbm-sdk/x/authz/codec"
 	govcodec "github.com/line/lbm-sdk/x/gov/codec"
@@ -19,19 +18,13 @@ func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
 	cdc.RegisterInterface((*AccountI)(nil), nil)
 	cdc.RegisterConcrete(&BaseAccount{}, "cosmos-sdk/BaseAccount", nil)
 	cdc.RegisterConcrete(&ModuleAccount{}, "cosmos-sdk/ModuleAccount", nil)
-	cdc.RegisterConcrete(&MsgEmpty{}, "cosmos-sdk/MsgEmpty", nil)
 
 	legacytx.RegisterLegacyAminoCodec(cdc)
 }
 
 // RegisterInterfaces associates protoName with AccountI interface
 // and creates a registry of it's concrete implementations
 func RegisterInterfaces(registry types.InterfaceRegistry) {
-	registry.RegisterImplementations((*sdk.Msg)(nil),
-		&MsgEmpty{},
-	)
-	msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
-
 	registry.RegisterInterface(
 		"cosmos.auth.v1beta1.AccountI",
 		(*AccountI)(nil),

diff --git a/x/auth/types/events.go b/x/auth/types/events.go
diff --git a/x/auth/types/keys.go b/x/auth/types/keys.go
@@ -11,9 +11,6 @@ const (
 	// StoreKey is string representation of the store key for auth
 	StoreKey = "acc"
 
-	// RouterKey defines the module's message routing key
-	RouterKey = ModuleName
-
 	// FeeCollectorName the root string for the fee collector account address
 	FeeCollectorName = "fee_collector"
 

diff --git a/x/auth/types/msgs.go b/x/auth/types/msgs.go
diff --git a/x/auth/types/msgs_test.go b/x/auth/types/msgs_test.go