Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace ExactArgs(0) with NoArgs - Triage finschia-sdk#1168 #96

Open
Tracked by #1
0Tech opened this issue Jan 11, 2024 · 2 comments
Open
Tracked by #1

chore: replace ExactArgs(0) with NoArgs - Triage finschia-sdk#1168 #96

0Tech opened this issue Jan 11, 2024 · 2 comments
Assignees
@jaeseung-bae
Labels
enhancement New feature or request

Comments

@0Tech
Copy link

0Tech commented Jan 11, 2024

No description provided.

@0Tech 0Tech mentioned this issue Jan 11, 2024
Open
96 tasks
@jaeseung-bae
Copy link

jaeseung-bae commented Jan 17, 2024 •
edited
Loading

Desc
  • cobra.ExactArgs(0) -> cobra.NoArgs
    • cobra.NoArgs enforces no args.
Suggestion(Abandon/Maintain/Submit)
  • Abandon
    • Good to submit to cosmos-sdk but it's chore. Upstream may reject it.
Links

@jaeseung-bae jaeseung-bae self-assigned this Jan 17, 2024
@jaeseung-bae jaeseung-bae changed the title Triage finschia-sdk#1168 chore: replace ExactArgs(0) with NoArgs - Triage finschia-sdk#1168 Jan 25, 2024
@0Tech 0Tech added enhancement New feature or request and removed needs-triage labels Jan 30, 2024
@jaeseung-bae
Copy link

Result: Submit NoArgs only in NewCmdSubmitCancelUpgradeProposal to cosmos-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaeseung-bae jaeseung-bae

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0Tech @jaeseung-bae