You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR makes sense to prevent potential thread-unsafe situation. But we need to consider if we really don't need to log PeerState value. If it's necessary, we need to implement extra logic instead of removing it when we make a PR at the upstream. (e.g. Logging in PickVoteToSend instead of PickSendVote)
@tnasu said that it wasn’t worth it when PickSendVote was called with the logging. Because of the logging too much. It cannot help us under the high-traffic network. So he decided to discard it.
No description provided.
The text was updated successfully, but these errors were encountered: