Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the thread-unsafe of PeerState logging #7

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 2 comments
Open
Tracked by #1

Fix the thread-unsafe of PeerState logging #7

0Tech opened this issue Nov 1, 2023 · 2 comments
Assignees

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

No description provided.

@tkxkd0159 tkxkd0159 changed the title Triage on ostracon#458 Fix the thread-unsafe of PeerState logging Nov 7, 2023
@tkxkd0159
Copy link
Member

This PR makes sense to prevent potential thread-unsafe situation. But we need to consider if we really don't need to log PeerState value. If it's necessary, we need to implement extra logic instead of removing it when we make a PR at the upstream. (e.g. Logging in PickVoteToSend instead of PickSendVote)

@tkxkd0159
Copy link
Member

@tnasu said that it wasn’t worth it when PickSendVote was called with the logging. Because of the logging too much. It cannot help us under the high-traffic network. So he decided to discard it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants