Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting and Windows support. #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve error reporting and Windows support. #35

wants to merge 2 commits into from

Conversation

ludovicchabant
Copy link

This changes does the following:

  • Use the proper path separator on Windows for filename type matches.
  • Add error reporting so we can tell what's going when something fails.

FelikZ
FelikZ reviewed Feb 28, 2017
View reviewed changes
Copy link
Owner

@FelikZ FelikZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, thanks for contribution!

It requires more time for review that I am currently have, so I will back to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelikZ FelikZ FelikZ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludovicchabant @FelikZ