Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataserver synthetic data #508

Merged
merged 25 commits into from
Aug 30, 2022
Merged

Dataserver synthetic data #508

merged 25 commits into from
Aug 30, 2022

Conversation

RyanTrojans
Copy link
Contributor

No description provided.

chaoyanghe and others added 25 commits August 22, 2022 13:13
remove unnecessary if
Update attack_defense_data_loader.py
…dataserver_synthetic_data

# Conflicts:
#	python/fedml/data/data_loader.py
@gitguardian
Copy link

gitguardian bot commented Aug 29, 2022

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4224807 AWS Keys f9d9015 python/fedml/data/data_loader.py View secret
3327641 AWS Keys 48986e1 python/fedml/data/data_loader.py View secret
3327641 AWS Keys 63fe2e4 python/fedml/data/data_loader.py View secret
3327641 AWS Keys a841630 python/fedml/data/data_loader.py View secret
4224807 AWS Keys a841630 python/fedml/data/file_operation.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@fedml-alex fedml-alex merged commit 2862596 into dev/v0.7.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants