Skip to content

Commit a3725bd

Browse files
committed
use StringBuilder instead of StringBuffer
1 parent e324754 commit a3725bd

File tree

8 files changed

+9
-10
lines changed

8 files changed

+9
-10
lines changed

src/main/java/org/codehaus/stax2/ri/Stax2EventReaderImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ public String getElementText() throws XMLStreamException
195195
// ??? do we need to update mPrePeekEvent now
196196

197197
String str = null;
198-
StringBuffer sb = null;
198+
StringBuilder sb = null;
199199

200200
/* Ok, fine, then just need to loop through and get all the
201201
* text...
@@ -217,7 +217,7 @@ public String getElementText() throws XMLStreamException
217217
str = curr;
218218
} else {
219219
if (sb == null) {
220-
sb = new StringBuffer(str.length() + curr.length());
220+
sb = new StringBuilder(str.length() + curr.length());
221221
sb.append(str);
222222
}
223223
sb.append(curr);

src/main/java/org/codehaus/stax2/ri/Stax2ReaderAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,7 @@ public String getPrefixedName()
837837
if (prefix == null || prefix.length() == 0) {
838838
return ln;
839839
}
840-
StringBuffer sb = new StringBuffer(ln.length() + 1 + prefix.length());
840+
StringBuilder sb = new StringBuilder(ln.length() + 1 + prefix.length());
841841
sb.append(prefix);
842842
sb.append(':');
843843
sb.append(ln);

src/main/java/org/codehaus/stax2/ri/Stax2ReaderImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public String getPrefixedName()
196196
if (prefix == null) {
197197
return ln;
198198
}
199-
StringBuffer sb = new StringBuffer(ln.length() + 1 + prefix.length());
199+
StringBuilder sb = new StringBuilder(ln.length() + 1 + prefix.length());
200200
sb.append(prefix);
201201
sb.append(':');
202202
sb.append(ln);

src/main/java/org/codehaus/stax2/ri/Stax2WriterAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ public void writeDTD(String rootName, String systemId, String publicId,
333333
/* This may or may not work... depending on how well underlying
334334
* implementation follows stax 1.0 spec (it should work)
335335
*/
336-
StringBuffer sb = new StringBuffer();
336+
StringBuilder sb = new StringBuilder();
337337
sb.append("<!DOCTYPE");
338338
sb.append(rootName);
339339
if (systemId != null) {

src/main/java/org/codehaus/stax2/ri/Stax2WriterImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void writeDTD(String rootName, String systemId, String publicId,
7777
/* This may or may not work... depending on how well underlying
7878
* implementation follows stax 1.0 spec (it should work)
7979
*/
80-
StringBuffer sb = new StringBuffer();
80+
StringBuilder sb = new StringBuilder();
8181
sb.append("<!DOCTYPE");
8282
sb.append(rootName);
8383
if (systemId != null) {

src/main/java/org/codehaus/stax2/ri/dom/DOMWrappingReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1978,7 +1978,7 @@ public String getPrefixedName()
19781978
if (prefix == null) {
19791979
return _internName(ln);
19801980
}
1981-
StringBuffer sb = new StringBuffer(ln.length() + 1 + prefix.length());
1981+
StringBuilder sb = new StringBuilder(ln.length() + 1 + prefix.length());
19821982
sb.append(prefix);
19831983
sb.append(':');
19841984
sb.append(ln);

src/main/java/org/codehaus/stax2/ri/typed/SimpleValueEncoder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ protected String encode(AsciiValueEncoder enc)
6161
if (enc.isCompleted()) { // fitted in completely?
6262
return new String(mBuffer, 0, last);
6363
}
64-
// !!! TODO: with Java 5, use StringBuilder instead
65-
StringBuffer sb = new StringBuffer(mBuffer.length << 1);
64+
StringBuilder sb = new StringBuilder(mBuffer.length << 1);
6665
sb.append(mBuffer, 0, last);
6766
do {
6867
last = enc.encodeMore(mBuffer, 0, mBuffer.length);

src/main/java/org/codehaus/stax2/typed/Base64Variants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public final class Base64Variants
6666
*/
6767
public final static Base64Variant MODIFIED_FOR_URL;
6868
static {
69-
StringBuffer sb = new StringBuffer(STD_BASE64_ALPHABET);
69+
StringBuilder sb = new StringBuilder(STD_BASE64_ALPHABET);
7070
// Replace plus with hyphen, slash with underscore (and no padding)
7171
sb.setCharAt(sb.indexOf("+"), '-');
7272
sb.setCharAt(sb.indexOf("/"), '_');

0 commit comments

Comments
 (0)