Skip to content

fix bug Option::unwrap() on a None value #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lihui-Gu
Copy link

The original code only checks whether start_of_indices is None, but it does not check whether end_of_indices is None. However, it still calls .unwrap() on end_of_indices later without verifying its validity. This leads to a potential panic when end_of_indices is actually None.

if start_of_indices.is_none() {
    return;
}

let start_of_indices = start_of_indices.unwrap(); // ✅ safe
let end_of_indices = end_of_indices.unwrap();     // ❌ if None,panic !!!

Code change:

match (start_of_indices, end_of_indices) {
    (Some(start), Some(end)) => {
        // safely use start, end
    }
    _ => return, 
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant