Update Core.swift to include deinit for removing notification observers

Author: nehadereddy

CHANGELOG.md

@@ -2,12 +2,15 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.0.3]
+- Implemented deinit to remove notification observers when the player is deinitialized, ensuring proper resource cleanup.
+
 ## [1.0.2]
 - Fixed video_source_bitrate in variantChanged events.
 - Fixed event transition calculations .
 
 ## [1.0.1]
-- Bug fixes and maintenance updates.
+- Fixed bugs and improved the accuracy of metrics parameter calculations during event transitions.
 
 ## [1.0.0]
 

Sources/FastpixiOSVideoDataCore/MonitorMetrics/PlaybackEventHandler.swift

@@ -9,7 +9,6 @@ public  class PlybackPulseHadler {
     public var dispatchNucleusEvent: NucleusState
     public var tokenId: String?
     public var actionableData: [String: Any]?
-    public var sdkDetails: [String: Any]
     public var userData: [String: Any]
     public var previousBeaconData: [String: Any]?
     public var previousVideoState: [String: Any] = [:]
@@ -44,10 +43,6 @@ public  class PlybackPulseHadler {
         self.actionableData = nucleusState.metadata
         self.tokenId = nucleusState.metadata["workspace_id"] as? String
         self.previousBeaconData = nil
-        self.sdkDetails = [
-            "fastpix_embed" : "fastpix-ios-core",
-            "fastpix_embed_version" : "1.0.0",
-        ]
         self.userData = FastPixUserDefaults.getViewerCookie()
         self.getFastPixAPI = formulateBeaconUrl(workspace: self.tokenId ?? "", config: self.actionableData ?? [:])
         self.eventDispatcher = ConnectionHandler(api: self.getFastPixAPI ?? "")
@@ -71,7 +66,6 @@ public  class PlybackPulseHadler {
                 fetchedVideoState = self.dispatchNucleusEvent.getVideoData()
             }
             let mergedData = mergeDictionaries(
-                self.sdkDetails,
                 eventAttr,
                 sessionData,
                 deviceDetails,

Sources/FastpixiOSVideoDataCore/MonitorMetrics/core.swift

@@ -50,32 +50,32 @@ public class NucleusState {
     ]
 
     public init(key: String, passableMetadata: [String: Any], fetchPlayheadTime: @escaping () -> Int,
-                    fetchVideoState: @escaping () -> [String:Any]) {
-            self.key = key
-            self.metadata = passableMetadata["data"] as! [String : Any]
-            self.utilMethods = commonMethods
-            self.getVideoData = fetchVideoState
-            self.getCurrentPlayheadTime = fetchPlayheadTime
-            self.playerInitializationTime = commonMethods.now()
-            self.isVideoPlaying = false
-            self.isVideoBuffering = false
-            self.isVideoSeeking = false
-            self.isVideoErrorOccured = false
-            self.playerDestroyed = false
-            self.data = [
-                "player_sequence_number": 1,
-                "view_sequence_number": 1,
-                "player_instance_id": commonMethods.getUUID().lowercased(),
-                "beacon_domain": (passableMetadata["configDomain"] as? String) ?? "metrix.ws",
-                "workspace_id": (self.metadata["workspace_id"] as? String) ?? "workspaceId"
-            ]
+                fetchVideoState: @escaping () -> [String:Any]) {
+        self.key = key
+        self.metadata = passableMetadata["data"] as! [String : Any]
+        self.utilMethods = commonMethods
+        self.getVideoData = fetchVideoState
+        self.getCurrentPlayheadTime = fetchPlayheadTime
+        self.playerInitializationTime = commonMethods.now()
+        self.isVideoPlaying = false
+        self.isVideoBuffering = false
+        self.isVideoSeeking = false
+        self.isVideoErrorOccured = false
+        self.playerDestroyed = false
+        self.data = [
+            "player_sequence_number": 1, 
+            "view_sequence_number": 1,
+            "player_instance_id": commonMethods.getUUID().lowercased(),
+            "beacon_domain": (passableMetadata["configDomain"] as? String) ?? "metrix.ws",
+            "workspace_id": (self.metadata["workspace_id"] as? String) ?? "workspaceId"
+        ]
 
-            self.lastCheckedEventTime = 0
-            self.dispatchEvent(event: "configureView", eventmetadata: [:])
-            
-            NotificationCenter.default.addObserver(self, selector: #selector(appWillTerminate), name: UIApplication.willTerminateNotification, object: nil)
-            NotificationCenter.default.addObserver(self, selector: #selector(appWillTerminate), name: UIScreen.didDisconnectNotification, object: nil)
-        }
+        self.lastCheckedEventTime = 0
+        self.dispatchEvent(event: "configureView", eventmetadata: [:])
+        
+        NotificationCenter.default.addObserver(self, selector: #selector(appWillTerminate), name: UIApplication.willTerminateNotification, object: nil)
+        NotificationCenter.default.addObserver(self, selector: #selector(appWillTerminate), name: UIScreen.didDisconnectNotification, object: nil)
+    }
 
     func emitEvents(event: String, eventmetadata: [String: Any]) {
         let currentTime = commonMethods.now()
@@ -245,7 +245,15 @@ public class NucleusState {
     func emitPulse() {
         dispatchEvent(event: "pulse", eventmetadata: [:])
     }
-    
+
+    deinit {
+        // Remove observer for app termination to avoid potential retain cycles or memory leaks
+        NotificationCenter.default.removeObserver(self, name: UIApplication.willTerminateNotification, object: nil)
+        
+        // Remove observer for screen disconnection
+        NotificationCenter.default.removeObserver(self, name: UIScreen.didDisconnectNotification, object: nil)
+    }
+
     func refreshViewData() {
         self.data.keys.forEach { key in
             if key.hasPrefix("view_") {