LuaMacro plugin: Enable win.GetFileTimes/win.SetFileTimes to get/set change time

[rohitab]

Description of the new feature or improvement

The Lua function win.GetFileTimes returns Creation time, Last access time, and Last write time as shown in the following code. It does not return Change time.

FarManager/plugins/luamacro/luafar/win.c

Lines 863 to 870 in 2326d88

	if (GetFileTime(hFile, &t_create, &t_access, &t_write))
	{
	lua_createtable(L, 0, 3);
	PutFileTimeToTableEx(L, &t_create, "CreationTime");
	PutFileTimeToTableEx(L, &t_access, "LastAccessTime");
	PutFileTimeToTableEx(L, &t_write, "LastWriteTime");
	res = 1;
	}

Similarly, win.SetFileTimes sets the same time values as shown in the following code. It does not set Change time.

FarManager/plugins/luamacro/luafar/win.c

Lines 917 to 923 in 2326d88

	if (ExtractFileTime(L, "CreationTime", &t_create, hFile))
	p_create = &t_create;
	if (ExtractFileTime(L, "LastAccessTime", &t_access, hFile))
	p_access = &t_access;
	if (ExtractFileTime(L, "LastWriteTime", &t_write, hFile))
	p_write = &t_write;
	lua_pushboolean(L, (p_create||p_access||p_write) && SetFileTime(hFile,p_create,p_access,p_write));

Could you please add support for getting and setting Change time as well? This would allow Lua macros to set and restore all file times, similar to the Preserve all timestamps feature in the Copy and Rename/Move dialogs.

Proposed technical implementation details (optional)

Use file::GetTime and file::SetTime instead of GetFileTime and SetFileTime respectively.

FarManager/far/platform.fs.hpp

Lines 258 to 260 in 2326d88

	bool GetTime(chrono::time_point* CreationTime, chrono::time_point* LastAccessTime, chrono::time_point* LastWriteTime, chrono::time_point* ChangeTime) const;
	bool SetTime(const chrono::time_point* CreationTime, const chrono::time_point* LastAccessTime, const chrono::time_point* LastWriteTime, const chrono::time_point* ChangeTime) const;

[johnd0e]

@shmuz

[shmuz]

@johnd0e, as you know I'm spending all my spare time nowadays on far2m, etc. and there's no ChangeTime there.

[johnd0e]

@shmuz, yes I know.
But still hope that some day you will be able to find some time.
Or at least give us your opinion about proposed implementation.

[shmuz]

1. It's not a proposed implementation here, it is just a suggestion to use the same code Far3 uses.
2. I respect you being a Far3 "patriot", but on the other hand you could help me a lot with far2m but you won't do that.

[johnd0e]

you could help me a lot with far2m but you won't do that.

I will be happy to help where I can.
At the moment I have no system where I could run far2m.

[rohitab]

@johnd0e Thank you for trying to get this issue resolved.

1. It's not a proposed implementation here, it is just a suggestion to use the same code Far3 uses.

@shmuz The suggestion and the proposed implementation are the same, i.e. to use different functions, ones that get/set 4 file times instead of 3. I'd be happy to submit a patch if someone can review and commit it.

[shmuz]

@rohitab

I'd be happy to submit a patch if someone can review and commit it.

It seems to be the right way. It won't guarantee immediate review and commit but the chances would be much higher.