Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock filter command for menus does not work #580

Open
rohitab opened this issue Dec 23, 2022 · 4 comments
Open

Lock filter command for menus does not work #580

rohitab opened this issue Dec 23, 2022 · 4 comments

Comments

@rohitab
Copy link
Contributor

rohitab commented Dec 23, 2022

Far Manager version

3.0.6074.0 x64

OS version

10.0.22623.1037

Other software

No response

Steps to reproduce

  1. Press F9 to show the menu bar
  2. Press L to open the Left dropdown menu
  3. Press the right Alt to enable filtering mode
  4. Type in file. The menu will now only show items with file in their name, viz. File owners and File links.
  5. Press Ctrl+Alt+L to lock the filter. The filter indicator will change from [file] to <file> indicating that the filter is locked.
  6. Press F10 or Esc to close the dropdown menu
  7. Press L to open the Left dropdown menu again

Expected behavior

The menu should show filtered items only since the filter was locked. The filter indicator should show <file>.

Actual behavior

The menu shows all items. The filter indicator is not displayed.

Note that the Lock filter command does not work in any of these menus either:

  • User menu F2
  • Change drive menu Alt+F1 and Alt+F2
  • Plugin commands menu F11
  • Configure plugins menu Alt+Shift+F9
  • Code pages menu in Viewer and Editor Shift+F8
  • Filters menu Ctrl+I
  • Configuration editor far:config

In all the above cases, the filter indicator changes to show that the filter is locked. However, closing and reopening the menu removes the filter.

@rohitab rohitab added the bug label Dec 23, 2022
@alabuzhev
Copy link
Contributor

The menu should show filtered items only since the filter was locked.

"Lock the filter" does not mean "make it permanent", but "stop accepting more letters into the filter and let the menu process the pressed keys as usual".

Menus can have user-configured or autogenerated hotkeys to invoke corresponding items.
The filter intercepts the input and hotkeys don't work, locking it allows to use the hotkeys again.

@rohitab
Copy link
Contributor Author

rohitab commented Dec 24, 2022

I see. Please feel free to remove the bug tag.

It would be a nice feature to have. Would you consider adding it as an enhancement?

@alabuzhev alabuzhev removed the bug label Dec 24, 2022
@alabuzhev
Copy link
Contributor

Persisting and restoring filter state sounds interesting.
However, unlike, say, panels, menus are not that unique, there is a legion of them all over the place.
Coming up with an universal solution (that would also cover menus spawned by plugins and macros) could be tricky, so no ETA for this.

@rohitab
Copy link
Contributor Author

rohitab commented Dec 25, 2022

No worries. I'll be happy to test it out whenever it's ready. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants