[pull] main from chromium:main #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fixes flickering between toolbar and webview when dragging. A small roundup gap seems to happen and reveals partial pixels of another color underneath. I'm adding an extra solid background of proper color (normal or incognito) that blends flawlessly with the toolbar and webview. Extracted the constant for tap strip height into the constant file. Fixed bad offset that caused the tab strip to show slightly over webview when rubberbanding the web page. Bug: 1275914, 1275916 Change-Id: I9e18fda0a74b146e35f484582b5015cf8232038f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313129 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Robbie Gibson <rkgibson@google.com> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/main@{#948902}
Profile::IsSupervised was previously used to support the legacy supervised users account type in ChromeOS. This type has been deprecated in M74 and accounts have been actively deleted since M89. Bug: 1275169 Change-Id: I679a4bbe7f914ea52663c1df4369d08607def5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314915 Reviewed-by: Monica Basta <msalama@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/main@{#948903}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02820ac924f7..f844b93c88c5 2021-12-07 jobay@chromium.org Skip memory test that causes failures on the tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1239550 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iacaa2f4033978524c21add2b28f8b06a1b8af741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320007 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948904}
https://chromium.googlesource.com/angle/angle.git/+log/920a0a7f699d..c899424ca78c 2021-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 558e41e to 111e348 (338 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I82dcea9129dde629506debc4ad5bfb947ff00b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320005 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948905}
IntRects are replaced with gfx::Rects. IntRects with negative sizes are supposed to have been addressed in previous CLs for the bug. Most IntSizes are replaced with gfx::Size. Others representing relative offsets are replaced with gfx::Vector2d. The steps to create this CL are similar to crrev.com/c/3252774. Bug: 738465 Change-Id: I334bbbd5efb6892dd6181b3b4733d0680c00769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312656 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#948906}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I90cac170414d0f95ed738776d601e4e24fb7a6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319458 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948907}
Updates the expires_after attribute for 353 histograms that show frequent access in the past 180 days. These are the 99% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2022-03-07. TBR=chromium-metrics-reviews@google.com Change-Id: I53613a5473d21f5d8402a3609c11a56084ad9361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319842 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Bot-Commit: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/main@{#948908}
Updates the expires_after attribute for 44 histograms that have been used to generate alerts in the past 180 days and do not already have a date later than or within 60 days of 2022-03-07. TBR=chromium-metrics-reviews@google.com Change-Id: I6f5a772fd232ff0edddc4ca5b49a14446b78bb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319841 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Bot-Commit: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/main@{#948909}
Server-backed state keys are not available on reven, but reven also doesn't support FRE/AutoRE, so don't block enterprise enrollment or device policy initialization on the availability of server-backed state keys. Bug: b:206775318 Change-Id: Ia3bc7e2ae7fed61bc0bc55070ddb1938cf44681f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310924 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roland Bock <rbock@google.com> Reviewed-by: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/main@{#948910}
Bug: 1273048 Change-Id: I786e950727a942f254ec9dca3f4b7c791967f305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314563 Commit-Queue: Tove Petersson <tovep@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#948911}
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I28f7eccc7311a3d1393cc5c437c0edc042322d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318621 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#948912}
https://chromium.googlesource.com/infra/infra.git/+log/e2de65e5c13c..31175eb1a271 2021-12-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from 2a42792ceaa3 to 13546045d694 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-chromium Please CC tikuta@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: tikuta@chromium.org Change-Id: I18137b2ddb31f0b49c21e5d41c4edfc12689bdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320136 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948913}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202112070100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/kSSwFZA71f5ALoVuued5YRJcZSBbTPBr5IiQt-CeBLcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I36a5f08f5eef6b40fcec88e8b72f829f3e5cfd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320010 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948914}
https://dawn.googlesource.com/dawn.git/+log/c7d4f2c9f1a1..683401528f8d 2021-12-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 60e457b8badc to ca3dfbe78d73 (6 revisions) 2021-12-07 jiawei.shao@intel.com Align offset to 4 bytes in writeTexture on depth stencil textures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I40f7c20266a72893592e1c7efbb24b8bac4fc071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320009 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948915}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f844b93c88c5..192c3d4ee119 2021-12-07 jobay@chromium.org Update NPM dependencies 2021-12-07 victorporof@chromium.org Fix regression: Fit to window scale is changing on selecting different zoom levels 2021-12-07 jobay@chromium.org Skip a11y tree test to unblock Chromium roll 2021-12-07 alexrudenko@chromium.org Fix visibility to unblock src-internal roll If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1256688,chromium:1277397 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8c3840d87336be81ecb19b39c4a61dbb9150387d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320143 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948916}
[COOP] - kCrossOriginEmbedderPolicyCredentiallessReportOnly - kCrossOriginEmbedderPolicyRequireCorpReportOnly [COOP] - kCoopAndCoepIsolatedReportOnly - kCrossOriginOpenerPolicySameOriginAllowPopupsReportOnly - kCrossOriginOpenerPolicySameOriginReportOnly Change-Id: I4eca4d7256df8b97c7a3c1c480561930334bab56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314899 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#948917}
…led. Bug: b:209421474 Change-Id: Ia354e9310b59dbc3256fed22ae23f652ca135d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317208 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Toshiki Kikuchi <toshikikikuchi@chromium.org> Cr-Commit-Position: refs/heads/main@{#948918}
Bug: 1275432 Change-Id: I08ff2c625a5f58bfc4d1c83b75c6be268786d7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318837 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#948919}
…S 10.11." This reverts commit a5bc4ab. Reason for revert: Breaks 10.11 tests https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.11%20Tests/67710/overview Original change's description: > [PartitionAlloc] Don't promote PA to the default zone on macOS 10.11. > > * Why? > On macOS 10.11, we can crash when CoreFoundation uses the initial system > zone to free() memory which was allocated by PartitionAlloc. > > For instance, see this stack (from the linked bug): > 5 libsystem_c.dylib 0x00007fff8e6056df abort + 129 > 6 libsystem_malloc.dylib 0x00007fff8a46f396 szone_error + 626 > 7 libsystem_malloc.dylib 0x00007fff8a468c9a free_large + 236 > 8 CoreFoundation 0x00007fff95119bc7 __CFDataDeallocate + 39 > 9 CoreFoundation 0x00007fff950f9aa3 CFRelease + 371 > > What happens is that CFRelease (in CoreFoundation) passes a pointer to > free_large(), which does not own it, and crashes. free_large() is part > of magazine_malloc, which is the default allocator on this macOS > release. This should not happen, as malloc() in libsystem_malloc should > dispatch to the right zone, and it does not happen on macOS >10.11. > > * Mitigation > To mitigate that, partially disable PartitionAlloc-Everywhere on macOS > 10.11. To that end, we register PartitionAlloc's zone as usual, but do > not promote it to be the default zone on Darwin 15.x, as returned by > uname(). > > This has the effect of *not* forwarding malloc(), free() (and friends) > to PartitionAlloc, which should bypass it almost entirely. However, we > still override "operator new/delete" and friends, meaning that all > allocations made in C++ from first-party code will be routed to > PartitionAlloc. > > * Does it work? > This is hacky, and likely somewhat brittle, but *should* work. In > particular, even if free() is called on data which was "operator new"'d, > as PartitionAlloc is still registered as *a* zone, free() inside > libsystem_malloc will still route it to PartitionAlloc correctly. And > symetrically for malloc() / operator delete. Furthermore, PartitionAlloc > checks that pointers passed to it are owned (which should not be > necessary, but happened), and kicks them back up to free() for proper > dispatching. So we should also be robust to cross-module new/delete > (which should not happen either). > > * Expected impact > This is likely to increase memory usage a bit on macOS 10.11. > > * Can we do better? > Perhaps, but a difficulty is that Chrome ships as a single binary on all > supported macOS releases. And some parts of PartitionAlloc are decided > at compile time. So we cannot entirely back off PartitionAlloc at > compile time for macOS 10.11 (which would be cleaner). > > Note to sheriff: If macOS 10.11-specific bugs are in range, this is > likely the culprit. > > Change-Id: I0dde53c1afb778708c33281f97298929d820b39c > Bug: 1268776 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313097 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Benoit Lize <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948899} Bug: 1268776 Change-Id: Ic771d6f9ef1a4aa9abfc16635321c9a086dc2299 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320216 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Owners-Override: Alex Ilin <alexilin@google.com> Owners-Override: Martin Šrámek <msramek@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#948920}
Roll Chrome Win32 PGO profile from chrome-win32-main-1638856478-110eafa1f2867544f710dc9549ba55bd46f29c71.profdata to chrome-win32-main-1638867400-0122b52c304aaf62d5919cf8c65c85c8a643fb8b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icf4ebb093ccadb7ace3ad63577aaeaf15279b990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320141 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948921}
This reverts commit 5c22913. Reason for reland: pref now has proper name Original change's description: > Revert "[Privacy Review][WebUI] Add viewed preference for Privacy Review" > > This reverts commit a647a47. > > Reason for revert: Team is changing feature name, reverting pref CL before it hits canary to remove need to migrate pref. > > Original change's description: > > [Privacy Review][WebUI] Add viewed preference for Privacy Review > > > > Add in a preference for if a user has viewed privacy review to enable > > easier A/B testing. Initial use case, plan to expand. > > > > Bug: 1215630 > > Change-Id: I0fdad51a9b55456e0ffebc7e22a17fab3842f414 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3303679 > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#946963} > > Bug: 1215630 > Change-Id: I56c4fc5d053bd11cf199a00df60692330911e1b0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310957 > Auto-Submit: Sean Harrison <harrisonsean@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/main@{#947040} Bug: 1215630 Change-Id: I2fd1e7d2cf3235d50580e0f8b8866a65a36a72cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313132 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/main@{#948922}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82f35125f49f..b5c7bf81ba5f 2021-12-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: I8dde2e078e8858e312d759b1c3baaf1282f90b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319661 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948923}
https://chromium.googlesource.com/catapult.git/+log/02439f647cbd..96b538653a6d 2021-12-07 yuhengh@chromium.org Revert "Fix telemetry.internal.browser.tab_unittest.TabTest.testTabIsAlive is flaky" 2021-12-07 yuhengh@chromium.org Fix telemetry.internal.browser.tab_unittest.TabTest.testTabIsAlive is flaky 2021-12-06 yuhengh@chromium.org Pass in environment to browser_options for unit tests 2021-12-06 rohpavone@chromium.org [fuchsia] Update web-engine tests to use py3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1246005,chromium:1273638 Tbr: sadrul@google.com Change-Id: If6b7766b93badddefc0887a82a5ed8b088af0bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320012 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948924}
Bug: 1157620 Change-Id: I0991d4da035c31bdf8f95021ce24f6ce292f946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313978 Commit-Queue: Bo Liu <boliu@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#948925}
Bug: 1254710 Change-Id: Ib3c5100c4ea057b560decd9a406d86c1f8ec1013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304157 Reviewed-by: Johannes Kron <kron@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Tove Petersson <tovep@chromium.org> Cr-Commit-Position: refs/heads/main@{#948926}
Groundwork for moving the rounding of ALS values to browser process. When the reading we get from sensor does not differ significantly from our current value, we discard this reading and do not emit any events. This is a privacy measure to avoid giving readings that are too specific. For now test in AmbientLightSensor.https.html is modified and not completely removed. Bug will be created to move this test to generic-sensor-tests.js. Test added for IsSignificantlyDifferent function. Bug: 1196238 Change-Id: I5af7860d2aa982296170d39bdfd282d1294bb191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289773 Auto-Submit: Juha J Vainio <juha.j.vainio@intel.com> Commit-Queue: Juha J Vainio <juha.j.vainio@intel.com> Reviewed-by: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#948927}
Change-Id: Ib0def98e72ee3e8bb6c6b9e4b380eb06c5872999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318300 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#948928}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )