[pull] main from chromium:main #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
… mac-rel Bug:1277277 Change-Id: I5f133c8669e4a30c9ed306e941745f6d2e6803f7 No-Try: true Change-Id: I5f133c8669e4a30c9ed306e941745f6d2e6803f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318282 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/main@{#948818}
https://gn.googlesource.com/gn.git/+log/e0afadf7a743..297669af11c7 2021-12-06 digit@google.com Use PointerSet<const Target> for TargetSet 2021-12-06 digit@google.com Add PointerSet<T> template. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/gn-chromium-autoroll Please CC thakis@chromium.org,dpranke@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,dpranke@chromium.org Change-Id: Ia76018468b0eba4ed00201d8680445e908cb89d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319516 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948819}
Terminal is opening on incorrect display when launching from a context menu shortcut. When launching via shelf click, it is OK since the ScopedDisplayForNewWindows created in ShelfView::ButtonPressed() is kept alive until ShelfView::ShelfItemStatusChanged() is called. However, the object created in AppServiceShelfContextMenu::ExecuteCommand() only lasts for the duration of that function, and it is destroyed before LaunchSystemWebAppImpl() is called async. Change-Id: Icb1f08c135e7b62d71849dd547c3bc33924022a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317010 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#948820}
I'm planning to add some histograms in //net behind this flag to have better understandings of possible radio wake-up triggers. Specifically we might add histograms for socket writes and HTTP/2 and QUIC pings. Bug: 1232623 Change-Id: I29f42448de6d72b2f6d8a0ca12d8ecd664025a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317258 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#948821}
This CL adds a new method to ACController which calls StartPrefetch() on all the providers. StartPrefetch() is a no-op method on the base ACProvider. Providers that wish to support prefetch requests would need to override this method and make sure not to notify the ACProviderListener of the matches resulting from a prefetch request. Bug: 1262373 Change-Id: I479aac5809bfc330b5da576919277a5b9082b43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309017 Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/main@{#948822}
This reverts commit 43a400e. Reason for revert: Fix race in browsertest to ensure the store is initialized before registering for the model in the guest profile. Original change's description: > Revert "[OptGuide] Support models for guest profiles." > > This reverts commit 74d499c. > > Reason for revert: crbug.com/1275335 > > Original change's description: > > [OptGuide] Support models for guest profiles. > > > > Previously, the guest profile would have a low, or no, chance of getting > > a model downloaded for each target. Rather than re-fetch for the guest > > profile, we should just re-use the default profile's available models. > > > > All the models and fetching are approved for off the record profiles > > as they disclose no information to Google and all the existing checks > > to validate this remain. > > > > Bug: 1274115 > > Change-Id: I11fa4a1c32f07a1ebafc804b336db61e4c543121 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307130 > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#946518} > > Bug: 1274115,1275335 > Change-Id: Ia2fea9819cb2ba747edd5092a2cfd64fd22529fe > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308147 > Auto-Submit: Darren Shen <shend@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/main@{#946756} Bug: 1274115,1275335 Change-Id: Ia5771c09ed8b3b147116e52647af514173e87700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310504 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#948823}
Chrome DCHECKs when testRunner.notifyDone is called from within ResizeObserver callback. Initially, I wanted to fix this inside Chrome's testRunner, but: - the testRunner fix is not trivial - these types of bugs are ResizeObserver callback specific - only occur when DCHECK is turned on This CL fixes the wpt test instead. This is much simpler, and we do not expect this to happen often enough to warrant C++ work. Bug: 1270820, 626703, 1275806 Change-Id: I0fbedb866998829d7b225ec8f09f5bdb4b7c8238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317248 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#948824}
https://chromium.googlesource.com/vulkan-deps.git/+log/5b3be708ab2f..b3dde75f5c88 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/876a1b9c34..3d3aae8fab * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/81195dfecb..2c2b81c051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com,cwallez@google.com Change-Id: Ieda06c5d708cf9bbc9fb404a8708fe4755fdc115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318597 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948825}
When adding a child before a block-in-inline already in the
tree, the |before_child| is in the anonymous block for the
block-in-inline.
```
LayoutBlockFlow
LayoutInline
LayoutBlockFlow (anonymous)
LayoutBlockFlow
LayoutBlockFlow <-- |before_child|
```
This patch fixes to insert a new block child as a child of the
existing anonymous box, before the |before_child|.
Test:
tables/mozilla/bugs/bug113235-1.html
Bug: 716930
Change-Id: I1cbe639fabad29e4ea54cc56ae2f298c3af9f186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318676
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#948826}
Bug: 1271401, 1275997 Change-Id: I671f82ac752ae44420527f41364ccb7b181fee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305997 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#948827}
Ash.Wallpaper.Source metric is currently recorded by the old Wallpaper Picker App. To fix, deprecate Ash.Wallpaper.Source metric and replace with the new Ash.Wallpaper.Source2. The new metric is correctly placed to be triggered by the new Wallpaper App. BUG=b/205163106 TEST=Manually Set different types of wallpapers (online, daily, custom & third party). Check the count histogram at chrome://histograms/Ash.Wallpaper.Source2, the count for each category should match the number of times that wallpaper type is set. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I4c4debd2e597ec44d38c35892b9c1f9a302f7b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309684 Reviewed-by: Tony Yeoman <tby@chromium.org> Reviewed-by: Josh Horwich <jhorwich@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Thuong Phan <thuongphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#948828}
Bug: 1272884 Change-Id: If54ec163d9a327958242f6c20a3b7d0e312fc096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296114 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#948829}
Bug: 1276143 Change-Id: I538d8190cf099e349f99b916fc5c63a0002e5e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313805 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#948830}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: Ie979022582e2af5a8166fa8a23b30a73f5ef873d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319816 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948831}
thawte.single.pem: was using for parsing tests. (It's also the same CA cert in google.chain.pem anyway.) googlenew.chain.pem: a different google cert from 2013. tls_feature_extension: was used for a test for a OCSP must-staple related histogram that expired comodo-chain.pem: was used for a CT integration test empty_subject_cert.der: was added for https://crbug.com/63988 but the code to use it never landed. www.ahrn.com.pem: something related to symantec_enforcement_disabled tests which is tested a different way now apparently. Bug: 1266634 Change-Id: I291729fd923e04163407f07b99a511065118576c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314327 Reviewed-by: Hubert Chao <hchao@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/main@{#948832}
Bug: 1272287 Change-Id: I9244fd534c4e77569fdb5c36a5eec328dc759d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312825 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/main@{#948833}
These were from old NSS verifier tests. (We have better, end-to-end AIA tests now which work cross-platform.) Updates a few tests that were using these certs as "just some random cert" to use some other random cert. Bug: 1266634 Change-Id: I4f43f2a791befc93ce41ce782b7cb062a5924426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315884 Reviewed-by: Hubert Chao <hchao@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/main@{#948834}
This CL simply causes lacros to match the behavior of ash. Bug: 1269553 Change-Id: Ic6a49d134a5a9f31ed08c8441646ab98de6b4bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315170 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#948835}
This feature was enabled by default in M85 so the flag is no longer needed. Bug: 935267 Change-Id: I9e04f665fdc4b0251aa458de5fb0b0d5b0324593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319596 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#948836}
Makes feature on by default. Moves OS gate from Finch into feature. Flag will be removed in a followup change. Fixed: 1271670 Change-Id: I77f856f6c507ed57976223ba69241d4d33ed609e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291934 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#948837}
Adds Memory.Total.RendererMalloc metric which reports the total malloc usage for all Renderer processes Bug: 1239629 Change-Id: Ib94184d343055b5d7464fd69807d7ed85dbab09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316139 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/main@{#948838}
https://dawn.googlesource.com/dawn.git/+log/1a57ee9d4e1d..c7d4f2c9f1a1 2021-12-07 junwei.fu@intel.com Make templates webgpu_cpp.h and webgpu_cpp_print.h flexible 2021-12-06 lokokung@google.com Revert "Bump maxUniformBindingSize to 2^16 from 2^14" 2021-12-06 enga@chromium.org Complete per-backend AdapterDiscoveryOptions 2021-12-06 enga@chromium.org Support multiple Vulkan instances in the Vulkan backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1266550 Tbr: cwallez@google.com Change-Id: Ie668d1768eaa54045b0450d7d5a1a5239fc9b24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319531 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948839}
We've migrated call sites via a series of 'git cl split' CLs. Once these all land, this can be submitted. Bug: 1244149 Change-Id: Id5145b1f96aea8b1e2bfd9d70caa14b2bb0eea77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299292 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/main@{#948840}
The IPH will be shown at most three times in last 90 days, and if the virtual card option has been selected by users at least twice in the last 90 days it will not be shown either. Mock: https://screenshot.googleplex.com/7yafJa5xSaE8fSZ Screenshot: https://screenshot.googleplex.com/6jzKEm27hcRmAwX Bug: 1243475 Change-Id: Ie5370cb6c28460b3507e9522d9efd7e3e439abc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288143 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/main@{#948841}
…re is now scheduled for launch in M99. Bug: 1229108 Change-Id: Id8fe30810296f3049091d36a11a8ee0f2ce359a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319038 Auto-Submit: Matthew Duggan <mduggan@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/main@{#948842}
https://pdfium.googlesource.com/pdfium.git/+log/44d713879ada..e6245932aa5b 2021-12-07 david@adalogics.com Add targeted XFA fuzzer with a few preconditions 2021-12-07 tsepez@chromium.org Add unit tests for fgas_fontutils.cpp 2021-12-06 bsheedy@chromium.org Remove Skia Gold master usage 2021-12-06 tsepez@chromium.org Move FX_FONTMATCHPARAMS to cfgas_fontmgr.cpp 2021-12-06 tsepez@chromium.org Use consistent constant for FGAS_FONTUSB::wBitField sentinel. 2021-12-06 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from dcc5002488c5 to 7b4a8bcadec9 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1276531,chromium:1276950 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3ed72bfbe72a1ddf465da84d134d85b9f13c8bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319637 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948843}
setBindGroup was previously split into additional overloads to avoid allocation of an empty vector for the default dynamicOffsets argument. This incorrectly made it impossible to pass |undefined| as the third argument since it was not optional. This fixes the idl to make the arg optional while preserving the original intent to avoid allocation of an empty vector. C++ overloads without the vector argument are still called if no third arg exists, or if undefined is passed. Bug: 852089 Change-Id: I29cd291126d7efbd3586bd61e6454bf1fc7eff0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318930 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/main@{#948844}
https://chromium.googlesource.com/angle/angle.git/+log/006c11d932fc..920a0a7f699d 2021-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a465cca8ec8d to 3e61a772b248 (4 revisions) 2021-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 840fab9 to 558e41e (627 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I97e614851d91dad2c9d94c557aef82a36ebd1938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319642 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948845}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: Ia8eee86bb364292644234bab9ad65b990753de17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319203 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948846}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638835205-87577541bf574d0431c2b4036fbd37b83aa6d4b2.profdata to chrome-win64-main-1638845609-0991408c5eca403a0ac4a7e202b5601f453bd29b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie484759145ffcaecb9351681fbb44c165295793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319649 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948847}
We added UMA for AX events here: https://crrev.com/c/3240642 But we have not observed any case recorded. This seems to be happening because of the mismatch between the UMA name in back_forward_cache_metrics.cc and histograms.xml. This CL fixes the mismatch. AX-Relnotes: n/a (non user-facing change) Bug: 1263346 Change-Id: I07998397541979c0bfa09063079d1592b0159665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316099 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#948848}
This change moves the collection being iterated over into a local variable in order to protect against synchronous Javascript execution when the Promise is resolved causing modification of the collection or similar memory errors that can arise from unexpected reentrancy. Note that in this case because the promise is being rejected and not resolve there isn't any potential for synchronous Javascript exeuction but it is safer to pretend that there could be. Bug: 1271968 Change-Id: Iaa5f4257e90565dd2b8d7e848286ee7370e8c01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319659 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/main@{#948849}
This reverts commit e017220. Reason for revert: Add package_root so that the path to the generated yaml files do not change. This cl also removes chromedriver from the perf builder. Previously the chromedriver target defined in //fuchsia/cipd was inadvertently being built. Original change's description: > Revert "[Fuchsia] Avoid duplicate target names in official builds." > > This reverts commit 3978d7d. > > Reason for revert: Broke fuchsia-builder-perf-fyi, among other builders. > > Original change's description: > > [Fuchsia] Avoid duplicate target names in official builds. > > > > Add `_archive` suffix to the CIPD binary targets > > > > Bug: 1182958 > > Change-Id: If7f61a02d7ac9a1407b31a93fc38692b3ab7e4a5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299070 > > Auto-Submit: Chong Gu <chonggu@google.com> > > Commit-Queue: Chong Gu <chonggu@google.com> > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#947420} > > Bug: 1182958 > Change-Id: Ieed09861c8a7d47405db319ef71374a4bc5c1af3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315423 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Srinivas Sista <srinivassista@chromium.org> > Commit-Queue: Rohan Pavone <rohpavone@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948164} Bug: 1182958 Change-Id: I688026d8b3f7769a9093de958a10870a35d2208e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315793 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/main@{#948850}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )