Skip to content

Commit f7d08a5

Browse files
Victor VasilievCommit Bot
Victor Vasiliev
authored and
Commit Bot
committed
Roll src/net/third_party/quiche/src/ c2e5361f3..d8fb72d5a (9 commits)
https://quiche.googlesource.com/quiche.git/+log/c2e5361f375a..d8fb72d5a $ git log c2e5361f3..d8fb72d5a --date=short --no-merges --format='%ad %ae %s' 2020-08-26 vasilvv Switch the experimental use of absl from absl::node_hash_map to absl::WrapUnique. 2020-08-26 vasilvv Add missing QUIC_EXPORT_PRIVATE attributes. 2020-08-26 renjietang Deprecate QuicSession::CloseStream(). 2020-08-26 quiche-dev Rename QuicSpdyStream::IsClosed() -> IsSequencerClosed(). 2020-08-26 vasilvv Attempt to use Abseil in QUICHE. 2020-08-26 bnc Test-only change 2020-08-25 danzh In IETF quic, start peer migration by switching peer address as soon as detecting a non-probing frame in the incoming packet rather than after finishing parsing the whole packet. Protected by --gfe2_reloadable_flag_quic_start_peer_migration_earlier. 2020-08-25 fayang Deprecate gfe2_reloadable_flag_quic_retransmit_handshake_data_early. 2020-08-25 fayang Deprecate gfe2_reloadable_flag_quic_fix_extra_padding_bytes. Created with: roll-dep src/net/third_party/quiche/src R=dschinazi@chromium.org Change-Id: Ieab7e0aaf9c8098f993036e75e0725eaaaadd72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378532 Reviewed-by: David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#802106}
1 parent f9c487f commit f7d08a5

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

DEPS

+1-1
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ vars = {
322322
# Three lines of non-changing comments so that
323323
# the commit queue can handle CLs rolling feed
324324
# and whatever else without interference from each other.
325-
'quiche_revision': 'c2e5361f375a0354cd0eb7cf6dea1e0c19555a4f',
325+
'quiche_revision': 'd8fb72d5ad9cb8ae3499b07b37b7857d88d26794',
326326
# Three lines of non-changing comments so that
327327
# the commit queue can handle CLs rolling ios_webkit
328328
# and whatever else without interference from each other.

net/quic/quic_chromium_client_session_test.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -1111,7 +1111,7 @@ TEST_P(QuicChromiumClientSessionTest, MaxNumStreams) {
11111111

11121112
// Close a stream and ensure I can now open a new one.
11131113
quic::QuicStreamId stream_id = streams[0]->id();
1114-
session_->CloseStream(stream_id);
1114+
session_->ResetStream(stream_id, quic::QUIC_RST_ACKNOWLEDGEMENT);
11151115

11161116
// Pump data, bringing in the max-stream-id
11171117
base::RunLoop().RunUntilIdle();
@@ -1302,7 +1302,7 @@ TEST_P(QuicChromiumClientSessionTest, ClosePendingStream) {
13021302
quic::QuicStreamFrame data(id, false, 1, quiche::QuicheStringPiece("SP"));
13031303
session_->OnStreamFrame(data);
13041304
EXPECT_EQ(0u, session_->GetNumActiveStreams());
1305-
session_->CloseStream(id);
1305+
session_->ResetStream(id, quic::QUIC_STREAM_NO_ERROR);
13061306
}
13071307

13081308
TEST_P(QuicChromiumClientSessionTest, CancelPushWhenPendingValidation) {
@@ -1362,7 +1362,8 @@ TEST_P(QuicChromiumClientSessionTest, CancelPushWhenPendingValidation) {
13621362
EXPECT_TRUE(session_->GetPromisedByUrl(pushed_url.spec()));
13631363

13641364
// Reset the stream now before tear down.
1365-
session_->CloseStream(GetNthClientInitiatedBidirectionalStreamId(0));
1365+
session_->ResetStream(GetNthClientInitiatedBidirectionalStreamId(0),
1366+
quic::QUIC_RST_ACKNOWLEDGEMENT);
13661367
}
13671368

13681369
TEST_P(QuicChromiumClientSessionTest, CancelPushBeforeReceivingResponse) {
@@ -1530,7 +1531,7 @@ TEST_P(QuicChromiumClientSessionTest, MaxNumStreamsViaRequest) {
15301531

15311532
// Close a stream and ensure I can now open a new one.
15321533
quic::QuicStreamId stream_id = streams[0]->id();
1533-
session_->CloseStream(stream_id);
1534+
session_->ResetStream(stream_id, quic::QUIC_RST_ACKNOWLEDGEMENT);
15341535
quic::QuicRstStreamFrame rst1(quic::kInvalidControlFrameId, stream_id,
15351536
quic::QUIC_STREAM_NO_ERROR, 0);
15361537
session_->OnRstStream(rst1);

net/quic/quic_flags_list.h

+7
Original file line numberDiff line numberDiff line change
@@ -446,3 +446,10 @@ QUIC_FLAG(bool,
446446
QUIC_FLAG(bool,
447447
FLAGS_quic_reloadable_flag_quic_enable_mtu_discovery_at_server,
448448
false)
449+
450+
// If true, while reading an IETF quic packet, start peer migration immediately
451+
// when detecting the existence of any non-probing frame instead of at the end
452+
// of the packet.
453+
QUIC_FLAG(bool,
454+
FLAGS_quic_reloadable_flag_quic_start_peer_migration_earlier,
455+
false)

0 commit comments

Comments
 (0)