Skip to content

Commit f1e8b17

Browse files
vabrCommit bot
vabr
authored and
Commit bot
committed
Fix installation of libgl1-mesa-dev and mesa-common-dev in install-build-deps.sh
On a fresh install of Ubuntu Trusty + Cinnamon, install-build-deps.sh failed, because: * it was looking for libgl1-mesa-dev * Cinnamon forced libgl1-mesa-dev-lts-utopic to be installed * there cannot be two versions of libgl1-mesa-dev* installed This CL adds libgl1-mesa-dev and mesa-common-dev to the group of packages, for which the correct "mesa_variant" suffix is guessed. It also adds "-lts-utopic" to the list of explored suffixes. BUG=466787 Review URL: https://codereview.chromium.org/1003853003 Cr-Commit-Position: refs/heads/master@{#320889}
1 parent b4eb247 commit f1e8b17

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

build/install-build-deps.sh

+13-12
Original file line numberDiff line numberDiff line change
@@ -102,16 +102,15 @@ dev_list="apache2.2-bin bison cdbs curl dpkg-dev elfutils devscripts fakeroot
102102
language-pack-fr language-pack-he language-pack-zh-hant
103103
libapache2-mod-php5 libasound2-dev libbrlapi-dev libav-tools
104104
libbz2-dev libcairo2-dev libcap-dev libcups2-dev libcurl4-gnutls-dev
105-
libdrm-dev libelf-dev libexif-dev libgconf2-dev libgl1-mesa-dev
106-
libglib2.0-dev libglu1-mesa-dev libgnome-keyring-dev libgtk2.0-dev
107-
libkrb5-dev libnspr4-dev libnss3-dev libpam0g-dev libpci-dev
108-
libpulse-dev libsctp-dev libspeechd-dev libsqlite3-dev libssl-dev
109-
libudev-dev libwww-perl libxslt1-dev libxss-dev libxt-dev libxtst-dev
110-
mesa-common-dev openbox patch perl php5-cgi pkg-config python
111-
python-cherrypy3 python-crypto python-dev python-numpy python-opencv
112-
python-openssl python-psutil rpm ruby subversion ttf-dejavu-core
113-
ttf-indic-fonts ttf-kochi-gothic ttf-kochi-mincho wdiff xfonts-mathml
114-
zip $chromeos_dev_list"
105+
libdrm-dev libelf-dev libexif-dev libgconf2-dev libglib2.0-dev
106+
libglu1-mesa-dev libgnome-keyring-dev libgtk2.0-dev libkrb5-dev
107+
libnspr4-dev libnss3-dev libpam0g-dev libpci-dev libpulse-dev
108+
libsctp-dev libspeechd-dev libsqlite3-dev libssl-dev libudev-dev
109+
libwww-perl libxslt1-dev libxss-dev libxt-dev libxtst-dev openbox
110+
patch perl php5-cgi pkg-config python python-cherrypy3 python-crypto
111+
python-dev python-numpy python-opencv python-openssl python-psutil
112+
rpm ruby subversion ttf-dejavu-core ttf-indic-fonts ttf-kochi-gothic
113+
ttf-kochi-mincho wdiff xfonts-mathml zip $chromeos_dev_list"
115114

116115
# 64-bit systems need a minimum set of 32-bit compat packages for the pre-built
117116
# NaCl binaries.
@@ -164,14 +163,16 @@ nacl_list="g++-mingw-w64-i686 lib32z1-dev
164163
# it depends on mesa, and only one version of mesa can exists on the system.
165164
# Hence we must match the same version or this entire script will fail.
166165
mesa_variant=""
167-
for variant in "-lts-quantal" "-lts-raring" "-lts-saucy" "-lts-trusty"; do
166+
for variant in "-lts-quantal" "-lts-raring" "-lts-saucy" "-lts-trusty" \
167+
"-lts-utopic"; do
168168
if $(dpkg-query -Wf'${Status}' libgl1-mesa-glx${variant} 2>/dev/null | \
169169
grep -q " ok installed"); then
170170
mesa_variant="${variant}"
171171
fi
172172
done
173173
dev_list="${dev_list} libgbm-dev${mesa_variant}
174-
libgles2-mesa-dev${mesa_variant}"
174+
libgles2-mesa-dev${mesa_variant} libgl1-mesa-dev${mesa_variant}
175+
mesa-common-dev${mesa_variant}"
175176
nacl_list="${nacl_list} libgl1-mesa-glx${mesa_variant}:i386"
176177

177178
# Some package names have changed over time

0 commit comments

Comments
 (0)