personalization: create skeleton SWA at chrome://personalization

Prepare to move wallpaper code out of
chrome://os-settings/wallpaper to new SWA.
Follow up CL will move existing wallpaper polymer code and browser
handler functionality, then delete os_settings wallpaper code.

BUG=b:182012553

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I778322076a3bc7057499a8ac58d7e333e41ae5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2737214
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#864009}

Author: cwmoo740

chrome/app/chromeos_strings.grdp

@@ -33,7 +33,7 @@
     Time limit removed for <ph name="APP_NAME">$1<ex>Gmail</ex></ph>
   </message>
 
-  <!-- Wallpaper Manager -->
+  <!-- Wallpaper Manager (Deprecated Chrome App Version) -->
   <message name="IDS_WALLPAPER_MANAGER_APP_NAME" desc="Name of the app which allows users to pick their wallpaper.">
     Wallpaper Picker
   </message>

chrome/browser/ash/web_applications/personalization_app_info.cc

@@ -0,0 +1,32 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ash/web_applications/personalization_app_info.h"
+
+#include <memory>
+
+#include "chrome/browser/ash/web_applications/system_web_app_install_utils.h"
+#include "chrome/browser/web_applications/components/web_application_info.h"
+#include "chromeos/components/personalization_app/personalization_app_url_constants.h"
+#include "chromeos/grit/chromeos_personalization_app_resources.h"
+#include "chromeos/strings/grit/chromeos_strings.h"
+#include "third_party/blink/public/mojom/manifest/display_mode.mojom.h"
+#include "ui/base/l10n/l10n_util.h"
+
+std::unique_ptr<WebApplicationInfo> CreateWebAppInfoForPersonalizationApp() {
+  std::unique_ptr<WebApplicationInfo> info =
+      std::make_unique<WebApplicationInfo>();
+  info->start_url = GURL(chromeos::kChromeUIPersonalizationAppURL);
+  info->scope = GURL(chromeos::kChromeUIPersonalizationAppURL);
+  info->title = l10n_util::GetStringUTF16(IDS_PERSONALIZATION_APP_TITLE);
+  web_app::CreateIconInfoForSystemWebApp(
+      info->start_url,
+      {{"app_icon_192.png", 192,
+        IDR_CHROMEOS_PERSONALIZATION_APP_ICON_192_PNG}},
+      *info);
+  info->display_mode = blink::mojom::DisplayMode::kStandalone;
+  info->open_as_window = true;
+
+  return info;
+}

chrome/browser/ash/web_applications/personalization_app_info.h

@@ -0,0 +1,15 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ASH_WEB_APPLICATIONS_PERSONALIZATION_APP_INFO_H_
+#define CHROME_BROWSER_ASH_WEB_APPLICATIONS_PERSONALIZATION_APP_INFO_H_
+
+#include <memory>
+
+struct WebApplicationInfo;
+
+// Return a WebApplicationInfo used to install the app.
+std::unique_ptr<WebApplicationInfo> CreateWebAppInfoForPersonalizationApp();
+
+#endif  // CHROME_BROWSER_ASH_WEB_APPLICATIONS_PERSONALIZATION_APP_INFO_H_

chrome/browser/chromeos/BUILD.gn

@@ -134,6 +134,7 @@ source_set("chromeos") {
     "//chromeos/components/multidevice",
     "//chromeos/components/multidevice:stub_multidevice_util",
     "//chromeos/components/multidevice/logging",
+    "//chromeos/components/personalization_app",
     "//chromeos/components/phonehub",
     "//chromeos/components/power",
     "//chromeos/components/print_management",
@@ -219,6 +220,7 @@ source_set("chromeos") {
     "//chromeos/resources:eche_bundle_resources_grit",
     "//chromeos/resources:help_app_resources_grit",
     "//chromeos/resources:media_app_resources_grit",
+    "//chromeos/resources:personalization_app_resources_grit",
     "//chromeos/resources:print_management_resources_grit",
     "//chromeos/resources:scanning_app_resources_grit",
     "//chromeos/services/assistant/public/cpp",
@@ -1292,6 +1294,8 @@ source_set("chromeos") {
     "../ash/web_applications/media_web_app_info.h",
     "../ash/web_applications/os_settings_web_app_info.cc",
     "../ash/web_applications/os_settings_web_app_info.h",
+    "../ash/web_applications/personalization_app_info.cc",
+    "../ash/web_applications/personalization_app_info.h",
     "../ash/web_applications/print_management_web_app_info.cc",
     "../ash/web_applications/print_management_web_app_info.h",
     "../ash/web_applications/scanning_system_web_app_info.cc",

chrome/browser/ui/BUILD.gn

@@ -2715,6 +2715,7 @@ static_library("ui") {
       "//chromeos/components/multidevice/logging",
       "//chromeos/components/network_ui:network_diagnostics_resource_provider",
       "//chromeos/components/network_ui:network_health_resource_provider",
+      "//chromeos/components/personalization_app",
       "//chromeos/components/phonehub",
       "//chromeos/components/phonehub:debug",
       "//chromeos/components/print_management",

chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -223,6 +223,8 @@
 #include "chromeos/components/media_app_ui/url_constants.h"
 #include "chromeos/components/multidevice/debug_webui/proximity_auth_ui.h"
 #include "chromeos/components/multidevice/debug_webui/url_constants.h"
+#include "chromeos/components/personalization_app/personalization_app_ui.h"
+#include "chromeos/components/personalization_app/personalization_app_url_constants.h"
 #include "chromeos/components/print_management/print_management_ui.h"
 #include "chromeos/components/print_management/url_constants.h"
 #include "chromeos/components/scanning/scanning_ui.h"
@@ -839,6 +841,10 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
   if (url.host_piece() == chrome::kChromeUIPluginVmInternalHost) {
     return &NewWebUI<chromeos::PluginVmInternalUI>;
   }
+  if (url.host_piece() == chromeos::kChromeUIPersonalizationAppHost &&
+      chromeos::features::IsWallpaperWebUIEnabled()) {
+    return &NewWebUI<chromeos::PersonalizationAppUI>;
+  }
 
 #if !defined(OFFICIAL_BUILD)
 #if !defined(USE_REAL_DBUS_CLIENTS)

chrome/browser/web_applications/BUILD.gn

@@ -112,6 +112,7 @@ source_set("web_applications") {
       "//chromeos/components/eche_app_ui",
       "//chromeos/components/help_app_ui",
       "//chromeos/components/media_app_ui",
+      "//chromeos/components/personalization_app",
       "//chromeos/strings",
       "//components/arc:arc_base",
       "//components/arc/mojom",

chrome/browser/web_applications/components/system_web_app_types.h

@@ -30,6 +30,7 @@ enum class SystemAppType {
   CONNECTIVITY_DIAGNOSTICS = 12,
   ECHE = 13,
   CROSH = 14,
+  PERSONALIZATION = 15,
 
   // When adding a new System App, remember to:
   //

chrome/browser/web_applications/proto/web_app.proto

@@ -73,6 +73,7 @@ message SystemWebAppDataProto {
     CONNECTIVITY_DIAGNOSTICS = 12;
     ECHE = 13;
     CROSH = 14;
+    PERSONALIZATION = 15;
   };
 
   optional SystemAppType system_app_type = 1;

chrome/browser/web_applications/system_web_app_manager.cc

@@ -64,6 +64,7 @@
 #include "chrome/browser/ash/web_applications/help_app_web_app_info.h"
 #include "chrome/browser/ash/web_applications/media_web_app_info.h"
 #include "chrome/browser/ash/web_applications/os_settings_web_app_info.h"
+#include "chrome/browser/ash/web_applications/personalization_app_info.h"
 #include "chrome/browser/ash/web_applications/print_management_web_app_info.h"
 #include "chrome/browser/ash/web_applications/scanning_system_web_app_info.h"
 #include "chrome/browser/ash/web_applications/terminal_system_web_app_info.h"
@@ -72,6 +73,7 @@
 #include "chromeos/components/connectivity_diagnostics/url_constants.h"
 #include "chromeos/components/help_app_ui/url_constants.h"
 #include "chromeos/components/media_app_ui/url_constants.h"
+#include "chromeos/components/personalization_app/personalization_app_url_constants.h"
 #include "chromeos/strings/grit/chromeos_strings.h"
 #include "extensions/common/constants.h"
 #if !defined(OFFICIAL_BUILD)
@@ -247,6 +249,16 @@ base::flat_map<SystemAppType, SystemAppInfo> CreateSystemWebApps(
         false;
   }
 
+  if (SystemWebAppManager::IsAppEnabled(SystemAppType::PERSONALIZATION)) {
+    infos.emplace(
+        SystemAppType::PERSONALIZATION,
+        SystemAppInfo(
+            "Personalization", GURL(chromeos::kChromeUIPersonalizationAppURL),
+            base::BindRepeating(&CreateWebAppInfoForPersonalizationApp)));
+    auto& personalization_info = infos.at(SystemAppType::PERSONALIZATION);
+    personalization_info.capture_navigations = true;
+  }
+
 #if !defined(OFFICIAL_BUILD)
   if (SystemWebAppManager::IsAppEnabled(SystemAppType::TELEMETRY)) {
     infos.emplace(
@@ -388,6 +400,8 @@ bool SystemWebAppManager::IsAppEnabled(SystemAppType type) {
       return false;
     case SystemAppType::ECHE:
       return base::FeatureList::IsEnabled(chromeos::features::kEcheSWA);
+    case SystemAppType::PERSONALIZATION:
+      return chromeos::features::IsWallpaperWebUIEnabled();
   }
 #else
   return false;

chrome/chrome_paks.gni

@@ -202,6 +202,7 @@ template("chrome_extra_paks") {
         "$root_gen_dir/chromeos/chromeos_help_app_resources.pak",
         "$root_gen_dir/chromeos/chromeos_media_app_bundle_resources.pak",
         "$root_gen_dir/chromeos/chromeos_media_app_resources.pak",
+        "$root_gen_dir/chromeos/chromeos_personalization_app_resources.pak",
         "$root_gen_dir/chromeos/chromeos_print_management_resources.pak",
         "$root_gen_dir/chromeos/chromeos_resources.pak",
         "$root_gen_dir/chromeos/chromeos_scanning_app_resources.pak",
@@ -233,6 +234,7 @@ template("chrome_extra_paks") {
         "//chromeos/resources:help_app_resources",
         "//chromeos/resources:media_app_bundle_resources",
         "//chromeos/resources:media_app_resources",
+        "//chromeos/resources:personalization_app_resources",
         "//chromeos/resources:print_management_resources",
         "//chromeos/resources:scanning_app_resources",
         "//ui/file_manager:file_manager_gen_resources",

chromeos/chromeos_strings.grd

@@ -1396,6 +1396,11 @@ Try tapping the mic to ask me anything.
       <message name="IDS_NETWORK_DIAGNOSTICS_VIDEO_CONFERENCING_PROBLEM_MEDIA_FAILURE" desc="Error message shown when a connection cannot be established to the video conferencing media servers">
         Unable to connect to media servers
       </message>
+
+      <!-- Personalization App -->
+      <message name="IDS_PERSONALIZATION_APP_TITLE" desc="Name of the system web app for personalizing ChromeOS.">
+        Wallpaper
+      </message>
     </messages>
   </release>
 </grit>

chromeos/chromeos_strings_grd/IDS_PERSONALIZATION_APP_TITLE.png.sha1

@@ -0,0 +1 @@
+4a629e521b00d56d08511bad0a29d723dc4ccfa0

chromeos/components/BUILD.gn

@@ -63,6 +63,7 @@ group("closure_compile") {
     "//chromeos/components/help_app_ui:closure_compile",
     "//chromeos/components/media_app_ui:closure_compile",
     "//chromeos/components/multidevice/debug_webui/resources:closure_compile",
+    "//chromeos/components/personalization_app:closure_compile",
     "//chromeos/components/print_management:closure_compile",
     "//chromeos/components/scanning:closure_compile",
     "//chromeos/components/system_apps:closure_compile",

chromeos/components/personalization_app/BUILD.gn

@@ -0,0 +1,25 @@
+# Copyright 2021 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+assert(is_chromeos, "Personalization App is Chrome OS only")
+
+static_library("personalization_app") {
+  sources = [
+    "personalization_app_ui.cc",
+    "personalization_app_ui.h",
+    "personalization_app_url_constants.cc",
+    "personalization_app_url_constants.h",
+  ]
+
+  deps = [
+    "//chromeos/resources:personalization_app_resources",
+    "//chromeos/strings",
+    "//content/public/browser",
+    "//ui/webui",
+  ]
+}
+
+group("closure_compile") {
+  deps = [ "resources:closure_compile" ]
+}

chromeos/components/personalization_app/DEPS

@@ -0,0 +1,6 @@
+include_rules = [
+  "-chrome",
+  "+chromeos/grit/chromeos_personalization_app_resources.h",
+  "+content/public/browser",
+  "+ui/webui",
+]

chromeos/components/personalization_app/OWNERS

@@ -0,0 +1 @@
+file://chromeos/assistant/OWNERS

chromeos/components/personalization_app/personalization_app_ui.cc

@@ -0,0 +1,53 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/components/personalization_app/personalization_app_ui.h"
+
+#include "chromeos/components/personalization_app/personalization_app_url_constants.h"
+#include "chromeos/grit/chromeos_personalization_app_resources.h"
+#include "chromeos/grit/chromeos_personalization_app_resources_map.h"
+#include "chromeos/strings/grit/chromeos_strings.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_ui_data_source.h"
+#include "ui/webui/mojo_web_ui_controller.h"
+
+namespace chromeos {
+
+namespace {
+
+void AddResources(content::WebUIDataSource* source) {
+  source->AddResourcePath("", IDR_CHROMEOS_PERSONALIZATION_APP_INDEX_HTML);
+  source->AddResourcePaths(
+      base::make_span(kChromeosPersonalizationAppResources,
+                      kChromeosPersonalizationAppResourcesSize));
+
+#if !DCHECK_IS_ON()
+  source->SetDefaultResource(IDR_CHROMEOS_PERSONALIZATION_APP_INDEX_HTML);
+#endif  // !DCHECK_IS_ON()
+}
+
+void AddStrings(content::WebUIDataSource* source) {
+  static constexpr webui::LocalizedString kLocalizedStrings[] = {
+      {"title", IDS_PERSONALIZATION_APP_TITLE}};
+  source->AddLocalizedStrings(kLocalizedStrings);
+  source->UseStringsJs();
+}
+
+}  // namespace
+
+PersonalizationAppUI::PersonalizationAppUI(content::WebUI* web_ui)
+    : ui::MojoWebUIController(web_ui) {
+  auto source = base::WrapUnique(
+      content::WebUIDataSource::Create(kChromeUIPersonalizationAppHost));
+
+  AddResources(source.get());
+  AddStrings(source.get());
+
+  auto* browser_context = web_ui->GetWebContents()->GetBrowserContext();
+  content::WebUIDataSource::Add(browser_context, source.release());
+}
+
+PersonalizationAppUI::~PersonalizationAppUI() = default;
+
+}  // namespace chromeos

chromeos/components/personalization_app/personalization_app_ui.h

@@ -0,0 +1,22 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_COMPONENTS_PERSONALIZATION_APP_PERSONALIZATION_APP_UI_H_
+#define CHROMEOS_COMPONENTS_PERSONALIZATION_APP_PERSONALIZATION_APP_UI_H_
+
+#include "ui/webui/mojo_web_ui_controller.h"
+
+namespace chromeos {
+
+class PersonalizationAppUI : public ui::MojoWebUIController {
+ public:
+  explicit PersonalizationAppUI(content::WebUI* web_ui);
+  PersonalizationAppUI(const PersonalizationAppUI&) = delete;
+  PersonalizationAppUI& operator=(const PersonalizationAppUI&) = delete;
+  ~PersonalizationAppUI() override;
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_COMPONENTS_PERSONALIZATION_APP_PERSONALIZATION_APP_UI_H_

chromeos/components/personalization_app/personalization_app_url_constants.cc

@@ -0,0 +1,12 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/components/personalization_app/personalization_app_url_constants.h"
+
+namespace chromeos {
+
+const char kChromeUIPersonalizationAppHost[] = "personalization";
+const char kChromeUIPersonalizationAppURL[] = "chrome://personalization";
+
+}  // namespace chromeos

chromeos/components/personalization_app/personalization_app_url_constants.h

@@ -0,0 +1,15 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_COMPONENTS_PERSONALIZATION_APP_PERSONALIZATION_APP_URL_CONSTANTS_H_
+#define CHROMEOS_COMPONENTS_PERSONALIZATION_APP_PERSONALIZATION_APP_URL_CONSTANTS_H_
+
+namespace chromeos {
+
+extern const char kChromeUIPersonalizationAppHost[];
+extern const char kChromeUIPersonalizationAppURL[];
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_COMPONENTS_PERSONALIZATION_APP_PERSONALIZATION_APP_URL_CONSTANTS_H_

chromeos/components/personalization_app/resources/BUILD.gn

@@ -0,0 +1,27 @@
+# Copyright 2021 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//third_party/closure_compiler/compile_js.gni")
+import("//tools/grit/grit_rule.gni")
+import("//ui/webui/resources/tools/generate_grd.gni")
+
+generate_grd("build_grd") {
+  input_files_base_dir = rebase_path(".", "//")
+  input_files = [
+    "index.html",
+    "icon_192.png",
+    "personalization_app.js",
+  ]
+  manifest_files = []
+  grd_prefix = "chromeos_personalization_app"
+  out_grd = "$target_gen_dir/${grd_prefix}_resources.grd"
+}
+
+js_type_check("closure_compile") {
+  is_polymer3 = true
+  deps = [ ":personalization_app" ]
+}
+
+js_library("personalization_app") {
+}

chromeos/components/personalization_app/resources/icon_192.png

@@ -0,0 +1,14 @@
+<!-- Copyright 2021 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+<!DOCTYPE html>
+<html dir="$i18n{textdirection}" lang="$i18n{language}">
+  <head>
+    <title>$i18n{title}</title>
+    <link rel="icon" type="image/png" sizes="192x192" href="icon_192.png">
+    <meta charset="utf-8">
+    <script type="module" src="personalization_app.js" defer></script>
+  </head>
+  <body>
+  </body>
+</html>