From e0c484d0397c0a98cd9e1d9573bcd0c5fb5da307 Mon Sep 17 00:00:00 2001 From: Rune Lillesveen Date: Fri, 2 Jul 2021 20:19:50 +0000 Subject: [PATCH] Adding deps for //remoting/host/security_key Fixes gn check failures. The remaining issue is a circular dependency between host/security_key:security_key and host:common. Bug: 1159013 Change-Id: Ibd5078abebe093496991d271099e5fa222ad03dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000818 Reviewed-by: Jamie Walch Reviewed-by: Dirk Pranke Commit-Queue: Rune Lillesveen Cr-Commit-Position: refs/heads/master@{#898316} --- .gn | 2 +- remoting/host/security_key/BUILD.gn | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.gn b/.gn index 7fd46d2cf41048..9820c342658b1a 100644 --- a/.gn +++ b/.gn @@ -69,7 +69,7 @@ no_check_targets = [ "//ppapi/proxy:ipc_sources", # 13 errors "//ppapi/proxy:proxy", # 5 errors "//ppapi/thunk:*", # 1071 errors - "//remoting/host/security_key:*", # 68 errors + "//remoting/host/security_key:*", # 10 errors "//remoting/host/win:*", # 43 errors "//remoting/ios/app/settings:*", # 6 errors "//remoting/protocol:*", # 3 errors diff --git a/remoting/host/security_key/BUILD.gn b/remoting/host/security_key/BUILD.gn index 49bb2b3e596f8d..b9c55c59385ef5 100644 --- a/remoting/host/security_key/BUILD.gn +++ b/remoting/host/security_key/BUILD.gn @@ -37,7 +37,10 @@ source_set("security_key") { "//ipc", "//mojo/public/cpp/platform", "//mojo/public/cpp/system", + "//net:net", + "//net/traffic_annotation:traffic_annotation", "//remoting/proto", + "//remoting/protocol:protocol", "//third_party/webrtc_overrides:webrtc_component", ] @@ -62,8 +65,11 @@ source_set("main") { "remote_security_key_main.h", ] deps = [ + ":security_key", "//base:debugging_buildflags", "//mojo/core/embedder", + "//remoting/host:base", + "//remoting/host:common", ] } @@ -101,8 +107,16 @@ source_set("unit_tests") { public_deps = [ ":test_support" ] deps = [ + ":security_key", "//mojo/core/test:test_support", + "//net:net", + "//net:test_support", + "//net/traffic_annotation:test_support", "//remoting:test_support", + "//remoting/host:common", + "//remoting/host:test_support", + "//remoting/host/setup:common", + "//remoting/protocol:protocol", ] if (is_posix) { @@ -129,6 +143,7 @@ static_library("test_support") { ] deps = [ + ":security_key", "//ipc", "//remoting/proto", "//testing/gtest",