From b9c345655ae9d8937f29db7bbdfe3ba214269607 Mon Sep 17 00:00:00 2001 From: Elly Fong-Jones Date: Wed, 21 Oct 2020 14:19:30 +0000 Subject: [PATCH] base: disable RepeatedWillBlockDoesNotCreateTooManyWorkers This test is flaky, I think by design. Bug: 1140651 Change-Id: I4f60d97b8fcc553407b33a260e91f1004615e88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488398 Commit-Queue: Etienne Pierre-Doray Reviewed-by: Etienne Pierre-Doray Cr-Commit-Position: refs/heads/master@{#819361} --- base/task/thread_pool/thread_group_impl_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/base/task/thread_pool/thread_group_impl_unittest.cc b/base/task/thread_pool/thread_group_impl_unittest.cc index 68d29a4f1f411c..c3deb3b6e2a599 100644 --- a/base/task/thread_pool/thread_group_impl_unittest.cc +++ b/base/task/thread_pool/thread_group_impl_unittest.cc @@ -1770,8 +1770,9 @@ class HoldWorkersObserver : public WorkerThreadObserver { // 4. Task A enters a second WILL_BLOCK ScopedBlockingCall. This should no-op // because there are already enough workers. // 5. Unblock HoldWorkersObserver and wait for all tasks to complete. +// Disabled: https://crbug.com/1140651 TEST_F(ThreadGroupImplImplStartInBodyTest, - RepeatedWillBlockDoesNotCreateTooManyWorkers) { + DISABLED_RepeatedWillBlockDoesNotCreateTooManyWorkers) { constexpr size_t kNumWorkers = 2U; HoldWorkersObserver worker_observer; StartThreadGroup(TimeDelta::Max(), // |suggested_reclaim_time|