Skip to content

Commit a92a90a

Browse files
Eric RomanCommit Bot
Eric Roman
authored and
Commit Bot
committed
Fix the network bug triage queries when there are multiple components.
Previously, our query would select all of Internals>Network>* and then subtract bugs with one of the out-of-scope components. The problem is this filters out bugs that contain both an in-scope and an out-of-scope bug component. The new queries use an additive approach that names each of the in-scope components directly. NOTRY=true Change-Id: I8526c49a38d45d41caa4d53b3c6103d281e7f4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367983 Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#800644}
1 parent e568976 commit a92a90a

File tree

1 file changed

+44
-2
lines changed

1 file changed

+44
-2
lines changed

net/docs/bug-triage.md

+44-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ of their two days working on bug triage/investigation.
88
## 1. Review untriaged bugs
99

1010
Look through [this list of untriaged
11-
bugs](https://bugs.chromium.org/p/chromium/issues/list?sort=pri%20-stars%20-opened&q=component%3AInternals%3ENetwork%20status%3Aunconfirmed%2Cuntriaged%20-component%3AInternals%3ENetwork%3ECookies%20-component%3AInternals%3ENetwork%3EDNS%20-component%3AInternals%3ENetwork%3ECookies%20-component%3AInternals%3ENetwork%3ECertificate%20-component%3AInternals%3ENetwork%3EReportingAndNEL%20-component%3AInternals%3ENetwork%3EDataUse%20-component%3AInternals%3ENetwork%3EEV%20-component%3AInternals%3ENetwork%3EDataProxy%20-component%3AInternals%3ENetwork%3ECertTrans%20-component%3AInternals%3ENetwork%3ENetworkQuality%20-component%3AInternals%3ENetwork%3EDoH%20-component%3AInternals%3ENetwork%3ENetInfo%20-component%3AInternals%3ENetwork%3EVPN%20-Needs%3DFeedback%20-Label%3ANetwork-Triaged).
11+
bugs](https://bugs.chromium.org/p/chromium/issues/list?sort=pri%20-stars%20-opened&q=status%3Aunconfirmed%2Cuntriaged%20-Needs%3DFeedback%20-Label%3ANetwork-Triaged%20component%3DInternals%3ENetwork%2CInternals%3ENetwork%3ECache%2CInternals%3ENetwork%3ESSL%2CInternals%3ENetwork%3EQUIC%2CInternals%3ENetwork%3EAuth%2CInternals%3ENetwork%3EHTTP2%2CInternals%3ENetwork%3EProxy%2CInternals%3ENetwork%3ELibrary%2CInternals%3ENetwork%3ELogging%2CInternals%3ENetwork%3EConnectivity%2CInternals%3ENetwork%3EDomainSecurityPolicy%2CInternals%3ENetwork%3ETrustTokens%2CInternals%3ENetwork%3EFilters%2CInternals%3ENetwork%3EFTP%2CInternals%3ENetwork%3ESDCH).
1212

1313
* Go through them in the given order (top to bottom).
1414
The link sorts them by priority and then recency.
@@ -56,7 +56,7 @@ crashers](https://goto.google.com/network_triage_internal#investigating-crashers
5656
## 2. Follow-up on issues with the Needs-Feedback label
5757

5858
Look through [this list of Needs=Feedback
59-
bugs](https://bugs.chromium.org/p/chromium/issues/list?sort=pri%20-modified&q=component%3AInternals%3ENetwork%20Needs%3DFeedback%20-component%3AInternals%3ENetwork%3ECookies%20-component%3AInternals%3ENetwork%3EDNS%20-component%3AInternals%3ENetwork%3ECookies%20-component%3AInternals%3ENetwork%3ECertificate%20-component%3AInternals%3ENetwork%3EReportingAndNEL%20-component%3AInternals%3ENetwork%3EDataUse%20-component%3AInternals%3ENetwork%3EEV%20-component%3AInternals%3ENetwork%3EDataProxy%20-component%3AInternals%3ENetwork%3ECertTrans%20-component%3AInternals%3ENetwork%3ENetworkQuality%20-component%3AInternals%3ENetwork%3EDoH%20-component%3AInternals%3ENetwork%3ENetInfo%20-component%3AInternals%3ENetwork%3EVPN).
59+
bugs](https://bugs.chromium.org/p/chromium/issues/list?sort=pri%20-modified&q=Needs%3DFeedback%20component%3DInternals%3ENetwork%2CInternals%3ENetwork%3ECache%2CInternals%3ENetwork%3ESSL%2CInternals%3ENetwork%3EQUIC%2CInternals%3ENetwork%3EAuth%2CInternals%3ENetwork%3EHTTP2%2CInternals%3ENetwork%3EProxy%2CInternals%3ENetwork%3ELibrary%2CInternals%3ENetwork%3ELogging%2CInternals%3ENetwork%3EConnectivity%2CInternals%3ENetwork%3EDomainSecurityPolicy%2CInternals%3ENetwork%3ETrustTokens%2CInternals%3ENetwork%3EFilters%2CInternals%3ENetwork%3EFTP%2CInternals%3ENetwork%3ESDCH).
6060

6161
* Go through them in the given order (top to bottom).
6262
The link sorts them by priority and then recency.
@@ -79,6 +79,48 @@ On the final day of your rotation, send a brief summary to net-dev@chromium.org
7979
detailing any interesting or concerning trends. Do not discuss any restricted
8080
bugs on the public mailing list.
8181

82+
## Covered bug components
83+
84+
Not all of the subcomponents of `Interals>Network` are handled by this rotation.
85+
86+
The ones that are included are:
87+
88+
```
89+
Internals>Network
90+
Internals>Network>Auth
91+
Internals>Network>Cache
92+
Internals>Network>Connectivity
93+
Internals>Network>DomainSecurityPolicy
94+
Internals>Network>Filters
95+
Internals>Network>FTP
96+
Internals>Network>HTTP2
97+
Internals>Network>Library
98+
Internals>Network>Logging
99+
Internals>Network>Proxy
100+
Internals>Network>QUIC
101+
Internals>Network>SDCH
102+
Internals>Network>SSL
103+
Internals>Network>TrustTokens
104+
```
105+
106+
The rest of the `Internals>Network` subcomponents are out of scope,
107+
and covered by separate rotations:
108+
109+
```
110+
Internals>Network>Certificate
111+
Internals>Network>CertTrans
112+
Internals>Network>Cookies
113+
Internals>Network>DataProxy
114+
Internals>Network>DataUse
115+
Internals>Network>DNS
116+
Internals>Network>DoH
117+
Internals>Network>EV
118+
Internals>Network>NetInfo
119+
Internals>Network>NetworkQuality
120+
Internals>Network>ReportingAndNEL
121+
Internals>Network>VPN
122+
```
123+
82124
## Management
83125

84126
* Your rotation will appear in Google Calendar as two days. You are expected to

0 commit comments

Comments
 (0)