From 971a6d4ec14b1a31f27814374100b8362825f0d8 Mon Sep 17 00:00:00 2001 From: Elly Fong-Jones Date: Fri, 3 May 2019 15:20:23 +0000 Subject: [PATCH] test server: be much more verbose in logging So far the linked bug has resisted reproduction outside of the bots; unconditionally log more state to help debug. Bug: 922068 Change-Id: Ia2d93a1cfc03c1ea2fb1055d3b9cfea764a85217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592682 Auto-Submit: Elly Fong-Jones Commit-Queue: David Benjamin Reviewed-by: David Benjamin Cr-Commit-Position: refs/heads/master@{#656380} --- net/test/spawned_test_server/local_test_server_posix.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/test/spawned_test_server/local_test_server_posix.cc b/net/test/spawned_test_server/local_test_server_posix.cc index 06c2fe285113cc..8c0b2a81b505a0 100644 --- a/net/test/spawned_test_server/local_test_server_posix.cc +++ b/net/test/spawned_test_server/local_test_server_posix.cc @@ -139,8 +139,8 @@ bool LocalTestServer::LaunchPython( // Log is useful in the event you want to run a nearby script (e.g. a test) in // the same environment as the TestServer. - VLOG(1) << "LaunchPython called with PYTHONPATH = " - << options.environment["PYTHONPATH"]; + LOG(ERROR) << "LaunchPython called with PYTHONPATH = " + << options.environment["PYTHONPATH"]; // Set CWD to source root. if (!base::PathService::Get(base::DIR_SOURCE_ROOT, @@ -150,6 +150,7 @@ bool LocalTestServer::LaunchPython( } options.fds_to_remap.push_back(std::make_pair(pipefd[1], pipefd[1])); + LOG(ERROR) << "Running: " << python_command.GetCommandLineString(); process_ = base::LaunchProcess(python_command, options); if (!process_.IsValid()) { LOG(ERROR) << "Failed to launch " << python_command.GetCommandLineString();