Skip to content

Commit 92bbc6c

Browse files
qinminCommit bot
qinmin
authored and
Commit bot
committed
Remove chrome_download_delegate.cc
We no longer need this file. The java side is still being used for intercepting context menu downloads. Review-Url: https://codereview.chromium.org/2886403005 Cr-Commit-Position: refs/heads/master@{#473010}
1 parent f69a6aa commit 92bbc6c

File tree

6 files changed

+0
-124
lines changed

6 files changed

+0
-124
lines changed

chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

-6
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.chromium.chrome.browser.UrlConstants;
2323
import org.chromium.chrome.browser.tab.EmptyTabObserver;
2424
import org.chromium.chrome.browser.tab.Tab;
25-
import org.chromium.content_public.browser.WebContents;
2625
import org.chromium.ui.base.WindowAndroid;
2726
import org.chromium.ui.base.WindowAndroid.PermissionCallback;
2827

@@ -58,8 +57,6 @@ public void onDestroyed(Tab tab) {
5857
mTab = null;
5958
}
6059
});
61-
62-
nativeInit(tab.getWebContents());
6360
}
6461

6562
/**
@@ -312,7 +309,4 @@ public void onRequestPermissionsResult(
312309
protected Context getContext() {
313310
return mContext;
314311
}
315-
316-
private native void nativeInit(WebContents webContents);
317-
private static native String nativeGetDownloadWarningText(String filename);
318312
}

chrome/browser/BUILD.gn

-2
Original file line numberDiff line numberDiff line change
@@ -2858,8 +2858,6 @@ split_static_library("browser") {
28582858
"android/document/document_web_contents_delegate.h",
28592859
"android/dom_distiller/distiller_ui_handle_android.cc",
28602860
"android/dom_distiller/distiller_ui_handle_android.h",
2861-
"android/download/chrome_download_delegate.cc",
2862-
"android/download/chrome_download_delegate.h",
28632861
"android/download/chrome_duplicate_download_infobar_delegate.cc",
28642862
"android/download/chrome_duplicate_download_infobar_delegate.h",
28652863
"android/download/dangerous_download_infobar_delegate.cc",

chrome/browser/android/chrome_jni_registrar.cc

-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
#include "chrome/browser/android/devtools_server.h"
4545
#include "chrome/browser/android/document/document_web_contents_delegate.h"
4646
#include "chrome/browser/android/dom_distiller/distiller_ui_handle_android.h"
47-
#include "chrome/browser/android/download/chrome_download_delegate.h"
4847
#include "chrome/browser/android/download/download_controller.h"
4948
#include "chrome/browser/android/download/download_manager_service.h"
5049
#include "chrome/browser/android/download/items/offline_content_aggregator_factory_android.h"
@@ -223,7 +222,6 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {
223222
{"DomDistillerContent",
224223
dom_distiller::content::android::RegisterDomDistiller},
225224
{"DomDistillerCore", dom_distiller::core::android::RegisterDomDistiller},
226-
{"ChromeDownloadDelegate", RegisterChromeDownloadDelegate},
227225
{"GCMDriver", gcm::android::RegisterGCMDriverJni},
228226
{"InstanceID", instance_id::android::RegisterInstanceIDJni},
229227
{"Invalidation", invalidation::android::RegisterInvalidationJni},

chrome/browser/android/download/chrome_download_delegate.cc

-77
This file was deleted.

chrome/browser/android/download/chrome_download_delegate.h

-36
This file was deleted.

chrome/browser/android/download/download_controller.cc

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "base/logging.h"
1515
#include "base/metrics/histogram_macros.h"
1616
#include "base/synchronization/lock.h"
17-
#include "chrome/browser/android/download/chrome_download_delegate.h"
1817
#include "chrome/browser/android/download/dangerous_download_infobar_delegate.h"
1918
#include "chrome/browser/android/download/download_manager_service.h"
2019
#include "chrome/browser/android/tab_android.h"

0 commit comments

Comments
 (0)