Skip to content

Commit 8edbebd

Browse files
author
brettw@chromium.org
committed
Move stringize_macros to base/strings.
This removes the unused L-string macros in the file. BUG= Review URL: https://codereview.chromium.org/12090083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179926 0039d316-1c4b-4281-b951-d872f2087c98
1 parent 61c5554 commit 8edbebd

15 files changed

+17
-72
lines changed

base/base.gyp

+1-1
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,8 @@
531531
'string_split_unittest.cc',
532532
'string_tokenizer_unittest.cc',
533533
'string_util_unittest.cc',
534-
'stringize_macros_unittest.cc',
535534
'stringprintf_unittest.cc',
535+
'strings/stringize_macros_unittest.cc',
536536
'synchronization/cancellation_flag_unittest.cc',
537537
'synchronization/condition_variable_unittest.cc',
538538
'synchronization/lock_unittest.cc',

base/base.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -397,9 +397,9 @@
397397
'string_util_win.h',
398398
'string16.cc',
399399
'string16.h',
400-
'stringize_macros.h',
401400
'stringprintf.cc',
402401
'stringprintf.h',
402+
'strings/stringize_macros.h',
403403
'supports_user_data.cc',
404404
'supports_user_data.h',
405405
'synchronization/cancellation_flag.cc',

base/stringize_macros.h base/strings/stringize_macros.h

+3-28
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
// symbols (or their output) and manipulating preprocessor symbols
77
// that define strings.
88

9-
#ifndef BASE_STRINGIZE_MACROS_H_
10-
#define BASE_STRINGIZE_MACROS_H_
9+
#ifndef BASE_STRINGS_STRINGIZE_MACROS_H_
10+
#define BASE_STRINGS_STRINGIZE_MACROS_H_
1111

1212
#include "build/build_config.h"
1313

@@ -28,29 +28,4 @@
2828
// STRINGIZE(B(y)) produces "myobj->FunctionCall(y)"
2929
#define STRINGIZE(x) STRINGIZE_NO_EXPANSION(x)
3030

31-
// The following are defined only on Windows (for use when interacting
32-
// with Windows APIs) as wide strings are otherwise deprecated.
33-
#if defined(OS_WIN)
34-
35-
// Second-level utility macros to let us expand symbols.
36-
#define LSTRINGIZE_NO_EXPANSION(x) L ## #x
37-
#define TO_L_STRING_NO_EXPANSION(x) L ## x
38-
39-
// L version of STRINGIZE(). For examples above,
40-
// LSTRINGIZE(A) produces L"FOO"
41-
// LSTRINGIZE(B(y)) produces L"myobj->FunctionCall(y)"
42-
#define LSTRINGIZE(x) LSTRINGIZE_NO_EXPANSION(x)
43-
44-
// Adds an L in front of an existing ASCII string constant (after
45-
// expanding symbols). Does not do any quoting.
46-
//
47-
// For example, if:
48-
// #define C "foo"
49-
//
50-
// Then:
51-
// TO_L_STRING(C) produces L"foo"
52-
#define TO_L_STRING(x) TO_L_STRING_NO_EXPANSION(x)
53-
54-
#endif // defined(OS_WIN)
55-
56-
#endif // BASE_STRINGIZE_MACROS_H_
31+
#endif // BASE_STRINGS_STRINGIZE_MACROS_H_
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4-
//
5-
// Unit tests for stringize_macros.h
64

7-
#include "base/stringize_macros.h"
5+
#include "base/strings/stringize_macros.h"
86

97
#include "testing/gtest/include/gtest/gtest.h"
108

@@ -29,31 +27,3 @@ TEST(StringizeTest, Ansi) {
2927
STRINGIZE(PREPROCESSOR_UTIL_UNITTEST_B(y)));
3028
EXPECT_STREQ("\"foo\"", STRINGIZE(PREPROCESSOR_UTIL_UNITTEST_C));
3129
}
32-
33-
#if defined(OS_WIN)
34-
35-
TEST(StringizeTest, Wide) {
36-
EXPECT_STREQ(
37-
L"PREPROCESSOR_UTIL_UNITTEST_A",
38-
LSTRINGIZE_NO_EXPANSION(PREPROCESSOR_UTIL_UNITTEST_A));
39-
EXPECT_STREQ(
40-
L"PREPROCESSOR_UTIL_UNITTEST_B(y)",
41-
LSTRINGIZE_NO_EXPANSION(PREPROCESSOR_UTIL_UNITTEST_B(y)));
42-
EXPECT_STREQ(
43-
L"PREPROCESSOR_UTIL_UNITTEST_C",
44-
LSTRINGIZE_NO_EXPANSION(PREPROCESSOR_UTIL_UNITTEST_C));
45-
46-
EXPECT_STREQ(L"FOO", LSTRINGIZE(PREPROCESSOR_UTIL_UNITTEST_A));
47-
EXPECT_STREQ(L"myobj->FunctionCall(y)",
48-
LSTRINGIZE(PREPROCESSOR_UTIL_UNITTEST_B(y)));
49-
EXPECT_STREQ(L"\"foo\"", LSTRINGIZE(PREPROCESSOR_UTIL_UNITTEST_C));
50-
}
51-
52-
TEST(ToLStringTest, Main) {
53-
EXPECT_STREQ(L"blat", TO_L_STRING_NO_EXPANSION("blat"));
54-
55-
EXPECT_STREQ(L"foo", TO_L_STRING(PREPROCESSOR_UTIL_UNITTEST_C));
56-
EXPECT_STREQ(L"blat", TO_L_STRING("blat"));
57-
}
58-
59-
#endif // defined(OS_WIN)

content/common/gpu/media/rendering_helper_gl.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include "base/bind.h"
1010
#include "base/mac/scoped_nsautorelease_pool.h"
1111
#include "base/message_loop.h"
12-
#include "base/stringize_macros.h"
12+
#include "base/strings/stringize_macros.h"
1313
#include "base/synchronization/waitable_event.h"
1414
#include "ui/gl/gl_bindings.h"
1515
#include "ui/gl/gl_context.h"

content/common/gpu/media/video_decode_accelerator_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#include "base/stl_util.h"
3434
#include "base/string_number_conversions.h"
3535
#include "base/string_split.h"
36-
#include "base/stringize_macros.h"
36+
#include "base/strings/stringize_macros.h"
3737
#include "base/synchronization/condition_variable.h"
3838
#include "base/synchronization/lock.h"
3939
#include "base/synchronization/waitable_event.h"

google_apis/google_api_keys.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include "base/lazy_instance.h"
1212
#include "base/logging.h"
1313
#include "base/memory/scoped_ptr.h"
14-
#include "base/stringize_macros.h"
14+
#include "base/strings/stringize_macros.h"
1515

1616
#if defined(GOOGLE_CHROME_BUILD) || defined(USE_OFFICIAL_GOOGLE_API_KEYS)
1717
#include "google_apis/internal/google_chrome_api_keys.h"

google_apis/google_api_keys_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include "base/lazy_instance.h"
3636
#include "base/logging.h"
3737
#include "base/memory/scoped_ptr.h"
38-
#include "base/stringize_macros.h"
38+
#include "base/strings/stringize_macros.h"
3939

4040
// This is the default baked-in value for OAuth IDs and secrets.
4141
static const char kDummyToken[] = "dummytoken";

media/base/media_posix.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include "base/file_path.h"
1010
#include "base/logging.h"
1111
#include "base/path_service.h"
12-
#include "base/stringize_macros.h"
12+
#include "base/strings/stringize_macros.h"
1313
#include "media/ffmpeg/ffmpeg_common.h"
1414

1515
#if !defined(USE_SYSTEM_FFMPEG)

media/base/sinc_resampler_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "base/command_line.h"
1313
#include "base/logging.h"
1414
#include "base/string_number_conversions.h"
15-
#include "base/stringize_macros.h"
15+
#include "base/strings/stringize_macros.h"
1616
#include "base/time.h"
1717
#include "build/build_config.h"
1818
#include "media/base/sinc_resampler.h"

net/base/net_errors.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
#include "base/basictypes.h"
88
#include "base/metrics/histogram.h"
9-
#include "base/stringize_macros.h"
9+
#include "base/strings/stringize_macros.h"
1010

1111
namespace {
1212

remoting/host/plugin/host_plugin.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include "base/at_exit.h"
1212
#include "base/basictypes.h"
1313
#include "base/logging.h"
14-
#include "base/stringize_macros.h"
14+
#include "base/strings/stringize_macros.h"
1515
#include "net/socket/ssl_server_socket.h"
1616
#include "remoting/base/plugin_thread_task_runner.h"
1717
#include "remoting/host/plugin/constants.h"

remoting/host/remoting_me2me_host.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include "base/single_thread_task_runner.h"
1919
#include "base/string_number_conversions.h"
2020
#include "base/string_util.h"
21-
#include "base/stringize_macros.h"
21+
#include "base/strings/stringize_macros.h"
2222
#include "base/synchronization/waitable_event.h"
2323
#include "base/threading/thread.h"
2424
#include "base/utf_string_conversions.h"

remoting/host/server_log_entry.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#include "remoting/host/server_log_entry.h"
66

77
#include "base/logging.h"
8-
#include "base/stringize_macros.h"
8+
#include "base/strings/stringize_macros.h"
99
#include "base/sys_info.h"
1010
#include "remoting/base/constants.h"
1111
#include "remoting/protocol/session.h"

remoting/host/server_log_entry_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// found in the LICENSE file.
44

55
#include "base/memory/scoped_ptr.h"
6-
#include "base/stringize_macros.h"
6+
#include "base/strings/stringize_macros.h"
77
#include "remoting/host/server_log_entry.h"
88
#include "testing/gtest/include/gtest/gtest.h"
99
#include "third_party/libjingle/source/talk/xmllite/xmlelement.h"

0 commit comments

Comments
 (0)